Fix: derive OSVersion and OSBuild from OSName in Default parameter set#362
Open
PhilipSiborgs wants to merge 1 commit intoOSDeploy:masterfrom
Open
Fix: derive OSVersion and OSBuild from OSName in Default parameter set#362PhilipSiborgs wants to merge 1 commit intoOSDeploy:masterfrom
PhilipSiborgs wants to merge 1 commit intoOSDeploy:masterfrom
Conversation
When Start-OSDCloud is invoked with -OSName (Default parameter set), OSVersion and OSBuild were left $null, which silently disabled the automatic OS cache to OSDCloudUSB in OSDCloud.ps1:986. DriverPacks were cached correctly, but the OS image was downloaded straight to C:\OSDCloud\OS and never persisted to the USB for future runs. Parsing OSName (e.g. 'Windows 11 25H2 x64') into OSVersion and OSBuild after it is resolved makes the downstream global state identical to the Legacy parameter set, restoring the expected auto-caching behavior without touching any caching logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Start-OSDCloud is invoked with -OSName (Default parameter set), OSVersion and OSBuild were left $null, which silently disabled the automatic OS cache to OSDCloudUSB in OSDCloud.ps1:986. DriverPacks were cached correctly, but the OS image was downloaded straight to C:\OSDCloud\OS and never persisted to the USB for future runs.
Parsing OSName (e.g. 'Windows 11 25H2 x64') into OSVersion and OSBuild after it is resolved makes the downstream global state identical to the Legacy parameter set, restoring the expected auto-caching behavior without touching any caching logic.