Repository navigation
Potential fix for frame-job hang after stale delegate release - #24
Closed
johnpetersa19 wants to merge 1 commit into
Closed
johnpetersa19 wants to merge 1 commit into
johnpetersa19 wants to merge 1 commit into
Conversation
Recover the owner's completion state and notify its condition variable when a late release finds the single-reference frame job already wiped. Keep the fallback limited to the reported stale-job state. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nThis proposes a narrowly scoped recovery for the hard freeze reported in #23. The hang dump indicates that a late release can encounter the owner's frame job after it has already been reset to its base vtable, while the owner completion flag remains clear and the main thread waits on the associated condition variable.\n\nWhen that exact stale-job state is detected (embedded owner/job layout, base vtable, no delegate, single reference, owner unlocked, and completion not yet set), this change atomically marks the owner complete and notifies one waiter. Other delegate cases retain their existing behavior.\n\n## Validation\n\n- make: 'build/rt/hle/delegate_null.o' está atualizado. \n- \n\nThis has not yet been verified on the affected Android device; the proposed recovery may drop the stale frame job's work, as described in the issue.