Repository navigation
fix: run detached portal summon --mode tmux off-TTY, add real tmux e2e - #1
Merged
Merged
Conversation
Follow-up to the repo-tethers BF1 tmux summon. - UX: non-interactive `stave portal summon --mode tmux` now runs the detached create instead of degrading to a preview. A detached `tmux new-session -d` needs no TTY, and the blocking attach stays gated off-TTY, so previewing was a wart. - e2e: new test_rig/portal-e2e leg drives `--mode tmux` against the ssh-host container and asserts the tmux session exists, its pane shows the stub agent's marker, and re-summon is idempotent. The ssh-host image gains a kept-alive `codex` stub so a summoner exists remotely. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the repo-tethers BF1 tmux summon (PR 1 of a 2-PR stack).
UX: non-interactive
stave portal summon --mode tmuxnow runs the detached create instead of degrading to a preview. A detachedtmux new-session -dneeds no TTY, and the blocking attach stays gated off-TTY, so previewing was a wart. Guarded so--mode print/--print-commandand real-TTY attach are unchanged.e2e: new
test_rig/portal-e2eleg drives--mode tmuxagainst the ssh-host container (forced off-TTY via</dev/null) and asserts the tmux session exists, its pane shows the stub agent's marker, and re-summon is idempotent. The ssh-host image gains a kept-alive/usr/bin/codexstub. Assertion sshes carryConnectTimeoutso a wedge fails rather than stalls.Deep-planned, deep-built, and reviewed (holistic + codex). Full CI gate green (build both platforms, vet,
go test -race, golangci-lint 0, shellcheck).🤖 Generated with Claude Code