Repository navigation
feat: learn repo tethers when a saga-member create fails post-materialize - #2
Merged
Merged
Conversation
…lize Follow-up to repo-tethers. A saga-member create whose repos are durably built but which then fails (e.g. --memory attach) previously recorded no co-occurrence tethers: the inner member create is suppressed and the success-path capture never runs on error. Capture it now, post-lock and best-effort, gated on durable materialization (spaceHasRepos). `stave saga add` deliberately does NOT capture: adding an already-captured space to a saga would double-count, and there is no schema-free way to tell a captured space from an uncaptured recovery member. Capturing at the failure point targets exactly the uncaptured recovery member with no manifest/provenance change, honoring strict-once-only. Stacked on the tmux-e2e branch (file-disjoint; stacked for delivery). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Nurozen
force-pushed
the
stave/saga-add-learning/stave
branch
from
August 27, 2026 05:36
3ec8c74 to
49616cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to repo-tethers (PR 2 of a 2-PR stack). Stacked on #1 — targets that branch; reviews/merges after it.
A saga-member create whose repos are durably built but which then fails (e.g.
--memoryattach) previously recorded no co-occurrence tethers: the inner member create is suppressed and the success-path capture never runs on error. This captures it — post-lock and best-effort, gated on durable materialization.Design note: capture happens at the create-failure point, NOT on
stave saga add. Adding an already-captured space to a saga would double-count, and there's no schema-free way to tell a captured space from an uncaptured recovery member. The failure-point approach targets exactly the uncaptured recovery member with no manifest/provenance change, honoring strict-once-only. (~12-lineservice.gochange + tests.)Deep-planned, deep-built, reviewed (holistic + codex; the double-capture was caught and this redesign resolves it). Full
go test -race ./...green across all 12 packages, golangci-lint 0.🤖 Generated with Claude Code