Repository navigation
Let a capture or perf run say which tier it measured - #2321
Merged
Merged
Conversation
shoot, drive and perf take --quality low|medium|high|ultra and pin it on the page; each run reads the tier back from the shell and fails when it disagrees. The old iteration preset is now --draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
shoot,driveandperftake--quality <low|medium|high|ultra>and pin that graphics tier on the game page (?quality=<tier>). Each run reads the tier back from the shell (data-jg-quality) and fails when it is missing or different, so a capture or perf record always names the tier it measured. Every capture summary printstier <tier>;perfechoesperf: tier <tier>and records it inquality.--quality draft|fulliteration mode is now the--draftswitch (low tier, half viewport,-draftfile names), onshoot,driveandperf;perf:gatetakes--drafttoo. An unknown--qualityvalue fails naming all four tiers.Changed
-low,-medium,-ultra), so an ultra shot cannot overwrite the high one it was compared against.Root cause:
--qualitycarried the iteration preset, not the graphics tier, so a culling lane that asked for ultra got the game's defaulthighon both sides of its comparison and could not prove a tier claim.