logseq_2: init at 2.0.1, logseq-og: rename from logseq, 0.10.15 -> 1.0.0-unstable-2026-05-28 - #516682
logseq_2: init at 2.0.1, logseq-og: rename from logseq, 0.10.15 -> 1.0.0-unstable-2026-05-28#516682TomaSajt wants to merge 7 commits into
Conversation
b6de90f to
4c9e2ce
Compare
|
based on the gh repo ( thanks for trying to build it btw!! |
|
Yes, this is the db version. |
Not at all, since the OG version is in "maintenance" mode, they will keep it alive but no more features, afaik. |
f5dfce8 to
43132a5
Compare
|
In theory, the OCaml packaging is done. I still have one TODO, but other than that, the PR is ready for review again. |
|
@vbgl could you take a quick look at whether I'm doing the OCaml packaging correctly? e.g. |
amarshall
left a comment
There was a problem hiding this comment.
logseq-og should be bin/logseq-og and also name in desktop file should be updated, so as to allow logseq and logseq-og installed simultaneously.
| stdenv.mkDerivation (finalAttrs: { | ||
| pname = "logseq"; | ||
| version = "0.10.15"; | ||
| version = "1.0.0"; |
There was a problem hiding this comment.
Consider using latest from Git instead, since that has crucial fixes:
- electron_41 support
- fixes various uses of logseq instead of logseq-og
There was a problem hiding this comment.
Upstream did NOT fix Electron 39+ support, the commit you're talking about just bumps the Electron version used.
Upstream is not responding to the issue: logseq/og#32
(The thing that's broken is plugin loading, so if you're not using plugins, using newer electron is fine)
There was a problem hiding this comment.
I updated to the latest revision anyways, because they changed the internals a little bit to not conflict with the non-OG version.
|
To the people, who are subscribed to this PR, have you had any issues with the Also, if anyone's on |
|
Another thing: what do you guys think, should the old If we ever backport this (which might not happen, honestly), I'll keep the stable branch's |
I was using the AppImage version, but this prompted me to finally check the PR package. I copied the two files for So far everything works without issues, although I don't use Logseq too heavily.. |
Just going to say I believe |
|
Pushed a commit adding the changes from logseq/og#50 allowing the usage of Electron 40+ for OG I did not review everything, but to be safe and to save filesize, I removed the minified |
Unfortunately I am hoping that since logseq 1 is open source, there will be sufficient community support to keep it working smoothly. This was the entire premise of its original marketing as fully open source software: so that it would continue to work when it is inevitably abandoned or enshittificated by the developer (bringing us to today). |
I second this. |
This is the new db based Logseq! I'm not sure how much issue it causes if you try this out but go back to using the old version.
Things have changed in the packaging since the last release.
First, we're using pnpm now, so the tooling had to be switched up. Using pnpm is a bit cleaner than yarn, but both have their pros and cons.
Second, the number of git repo based clojure dependencies have increased significantly, so instead of manually patching in each git repo source, I opted to dive into the source code of the clojure CLI to figure out how to trick it into using prefetched git dependencies.
The main trick was just letting it first clone everything into it's normal location and then strip down the bare repos into the smallest form that the CLI still thinks is valid.
Third, there is a new cli tool, which would be installed to the PATH upon running the desktop app, but I patched it out and added it into $out/bin. Though, this means that I had to rename the desktop app's executable name to something else.
This CLI app is generated from OCaml, so I had to add some unpackaged OCaml packages to passthru.
Electron 40+ support was fixed in logseq/logseq#12741
TODO: figure out how to circumvent the
venvlogic inside the package.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.