logseq: pin electron to electron_39 to fix plugin loading - #515504
Conversation
There was a problem hiding this comment.
Electron 39 is EOL tomorrow
https://endoflife.date/electron
Edit: I see you're already aware of this from the issue comment. It's not obvious to me what Electron version the nightly version is on, but if that supports a secure version of Electron, temporarily updating the package to an unstable version would be preferable over keeping an insecure dependency IMHO. Feel free to dismiss this review if you prefer sticking to Electron 39.
|
Upstream has gone through a sizable refactor since the last release, making a quick update to unstable difficult. However, upstream is still using electron_39 in the latest commit, so my guess is that the issue is still not fixed. I'll try it with electron_40 when I manage to compile the latest revision. |
|
Btw I managed to build the latest revision (#516682), but it still doesn't work with Electron 40+ |
|
I'm gonna merge this for now and we'll figure out a solution later. |
|
Successfully created backport PR for |
Closes #506354
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.