#4 Wiki Editing in tree structure - toggle button - #5
Conversation
marius-meissner
left a comment
marius-meissner
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Nice test coverage btw. 👍
Changes have been deployed to the staging system successfully.
@TobiNeo Please have a look from your side as well.
| <?php if ($contentContainer->can(AdministerPages::class)): ?> | ||
| <a href="<?= Url::current(['toggle-wiki-tree-editing']) ?>" class="btn btn-info btn-sm toggle-editing"> | ||
| <?= $editingEnabled ? Yii::t('WikiModule.base', 'Disable wiki tree editing') : Yii::t('WikiModule.base', 'Enable wiki tree editing') ?> | ||
| </a> | ||
| <?php endif; ?> |
There was a problem hiding this comment.
The toggle buttons already take up a lot of space. Therefore, please nest them in a dropdown. You can call them options, for example.
|
Hello @marius-meissner , |
marius-meissner
left a comment
marius-meissner
left a comment
There was a problem hiding this comment.
Changes have been successfully deployed to staging.
@TobiNeo Please have a look from your side as well.
Looks good from my side, one tiny suggestion.
|
Hello @marius-meissner , |
|
Thanks Vidhya. As discussed, I will prepare your next task ASAP- probably today or tomorrow.
@marius-meissner: |
@TobiNeo |
Hi Vidhya, Looks good from my perspective :) |
marius-meissner
left a comment
marius-meissner
left a comment
There was a problem hiding this comment.
LGTM.
Changes will be deployed soon to prod. system.
@vidhyasagargm Please create a upstream PR. Maybe some coordination is required, as the PR is based on your other PR humhub#357.
3 participants
Hello @marius-meissner,
TO solve the issue #4, A toggle button has been implemented in order to toggle between enabling and disabling editing the wiki tree structure. The code is ready for review.