Skip to content

Wiki-tree-editing-toggle-button - #373

Merged
luke- merged 4 commits into
humhub:masterfrom
Neo-Atlas:wiki-tree-editing-toggle
Apr 15, 2025
Merged

Wiki-tree-editing-toggle-button#373
luke- merged 4 commits into
humhub:masterfrom
Neo-Atlas:wiki-tree-editing-toggle

Conversation

@vidhyasagargm

@vidhyasagargm vidhyasagargm commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

With editor permissions in the Wiki tree structure, it is quite easy to move articles accidentially:
image

A toggle button has been implemented in order to toggle between enabling and disabling editing the wiki tree structure.
Screenshot from 2025-04-01 20-16-51
Screenshot from 2025-04-01 20-17-09

An internal code review process has already been done upfornt for all the changes in this PR and ISSUE

@mbumpalumpa

Copy link
Copy Markdown
Contributor

@vidhyasagargm, thank you for the PR. We have reviewed it, and here are our thoughts.

We would like to suggest a different approach. Adding additional buttons will inevitably cause issues with translations, potentially making the buttons too large. Also, when adding this, we need to consider the Enterprise Theme version of the Wiki Module layout, as it's not the same as the default (HumHub Theme).

wiki layout

Our suggestion would be to go with a less UI-invasive and simpler approach: introduce a short delay before showing the "Move" button when a user hovers over a wiki page. This way, we prevent accidental reordering while keeping the UI unchanged and only slightly adjusting the UX.

You can see in the video how it should work.

delay-move-function.mp4

@vidhyasagargm

Copy link
Copy Markdown
Contributor Author

Greetings @mbumpalumpa,
Thanks a lot for your feedback. I will make the suggested changes and get back to you soon.

@vidhyasagargm

vidhyasagargm commented Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

Greetings @mbumpalumpa,
The suggested changes has been completed and pushed. Let me know if any other changes required.

@mbumpalumpa

Copy link
Copy Markdown
Contributor

@vidhyasagargm, I tried to test the PR, but the hover delay doesn’t seem to work. I assume it’s due to the .less not being compiled when running grunt. Could you please upload a version with the compiled .less?

@vidhyasagargm

Copy link
Copy Markdown
Contributor Author

Greetings @mbumpalumpa,
I have uploaded a version with the compiled files.

@luke-

luke- commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

@vidhyasagargm Thanks for the new version.

@yurabakhtin Can you please review?

@yurabakhtin

Copy link
Copy Markdown
Contributor

Can you please review?

@luke- I have tested, it works well, as the video from the comment.

@luke-
luke- merged commit aa209c0 into humhub:master Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants