Skip to content

Fix SKU allocation validation bypass #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sinck wants to merge 3 commits into
base: main
Choose a base branch
from
+426 −112
Open

Fix SKU allocation validation bypass #5053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04543c2
Fix SKU validation allocation bypass
Sinck Aug 17, 2026
d4007bb
Add SKU bypass regression coverage
Sinck Aug 19, 2026
0f804a3
Clarify SKU validation bypass behavior
Sinck Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/api-core/src/cfg/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,8 +811,8 @@ be propagated there by DPF.
| Field | Type | Default | Description |
| ------- | ------ | --------- | ------------- |
| `enabled` | `bool` | `false` | Enable BOM/SKU validation. |
| `ignore_unassigned_machines` | `bool` | `false` | Let machines without a SKU bypass validation. |
| `allow_allocation_on_validation_failure` | `bool` | `false` | Keep machines allocatable even when validation fails. |
| `ignore_unassigned_machines` | `bool` | `false` | When enabled, a machine that remains unassigned can skip BOM validation and proceed; machines with an assigned SKU are still validated. |
| `allow_allocation_on_validation_failure` | `bool` | `false` | Let machines with assigned SKUs proceed after validation failure; a missing SKU can be transiently reported until the next reconciliation. Does not bypass unassigned machines. |
| `find_match_interval` | `Duration` | `5m` | Interval between SKU match attempts. |
| `auto_generate_missing_sku` | `bool` | `false` | Auto-create missing SKUs from expected machines. |
| `auto_generate_missing_sku_interval` | `Duration` | `5m` | Interval between auto-generate attempts. |
Expand Down
Loading
Loading