Skip to content

Fix SKU allocation validation bypass - #5053

Open
Sinck wants to merge 1 commit into
NVIDIA:mainfrom
Sinck:fix/sku-validation-bypass-v2
Open

Fix SKU allocation validation bypass#5053
Sinck wants to merge 1 commit into
NVIDIA:mainfrom
Sinck:fix/sku-validation-bypass-v2

Conversation

@Sinck

@Sinck Sinck commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This prevents allow_allocation_on_validation_failure from allowing a machine without an assigned SKU to skip SKU assignment. The two policies now retain distinct semantics: explicitly ignoring unassigned machines is separate from allowing validation failures for an assigned SKU.

Related issues

None.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Review the policy split: ignore_unassigned_machines applies only when no SKU is assigned, while allow_allocation_on_validation_failure applies only after validation of an assigned SKU fails.

@Sinck
Sinck requested review from a team and polarweasel as code owners August 17, 2026 15:07
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant