cuda.core.system: Add support for getting and clearing field values
#1446
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
There was a problem hiding this comment.
Pull request overview
This PR adds support for field values APIs to cuda.core.system, enabling retrieval and clearing of numeric singleton metadata about CUDA devices through NVML. The implementation follows NVML's capabilities, which support getting and clearing field values but not setting them.
Key changes:
- New
FieldValueandFieldValuesclasses for managing field value data and collections Device.get_field_values()andDevice.clear_field_values()methods for interacting with field values- Improved naming in bindings layer: renamed
FIenum toFieldIdfor better clarity - Enhanced input validation in
_cast_field_values()for field ID tuples
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| cuda_core/cuda/core/system/_device.pyx | Adds FieldValue, FieldValues classes and Device methods for getting/clearing field values |
| cuda_core/tests/system/test_system_device.py | Adds comprehensive test coverage for get_field_values functionality |
| cuda_core/docs/source/api.rst | Adds API documentation entries for new FieldId, FieldValue, and FieldValues classes |
| cuda_bindings/cuda/bindings/_nvml.pyx | Renames FI to FieldId and adds validation for field value tuples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
2 participants
This adds support for the APIs around "field values" which are pieces of numeric singleton metadata about devices. Given the capabilities of NVML, they can be retrieved or cleared, but not set.