-
Notifications
You must be signed in to change notification settings - Fork 236
cuda.core.system: Add APIs related to events #1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds event-related APIs to the cuda.core.system module, enabling applications to register and wait for hardware events from CUDA devices. The implementation provides a high-level Python interface over NVML's event system.
Key changes include:
- Addition of
EventType,EventData, andDeviceEventsclasses for event handling - New
Device.register_events()andDevice.get_supported_event_types()methods - Refactored system event handling in NVML bindings with proper versioned API usage
- Array size fixes in NumPy dtype definitions for proper struct array handling
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| cuda_core/tests/system/test_system_device.py | Adds test coverage for event registration and timeout behavior |
| cuda_core/docs/source/api.rst | Documents new public API classes: DeviceEvents, EventData, EventType |
| cuda_core/cuda/core/system/_device_utils.pxi | Removes unused import and cleans up internal documentation |
| cuda_core/cuda/core/system/_device.pyx | Implements EventType, EventData, and DeviceEvents classes with device event APIs |
| cuda_bindings/cuda/bindings/_nvml.pyx | Refactors system event functions to use versioned structs and fixes array dtype definitions |
| cuda_bindings/cuda/bindings/_nvml.pxd | Removes old system event declarations and typedef |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
05cca22 to
fe4aae4
Compare
|
/ok to test |
|
|
/ok to test |
Prerequsite: #1446
Description