Skip to content

Fix averaging for MoE z-loss metric tracking #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marks101 wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −1
Open

Fix averaging for MoE z-loss metric tracking #3199

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0177b6
Fix averaging for MoE z-loss metric tracking
Feb 2, 2026
08fa785
Merge branch 'main' into fix-zloss-tp-metric-tracking
Feb 5, 2026
2ab2820
Merge branch 'main' into fix-zloss-tp-metric-tracking
Mar 2, 2026
516e6f9
Merge branch 'main' into fix-zloss-tp-metric-tracking
ilml Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion megatron/core/transformer/moe/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,11 @@ def apply_z_loss(self, logits, padding_mask: Optional[torch.Tensor] = None):
layer_number = self.layer_number

save_to_aux_losses_tracker(
"z_loss", z_loss / moe_z_loss_coeff, layer_number, num_layers
"z_loss",
z_loss / moe_z_loss_coeff,
layer_number,
num_layers,
avg_group=self.tp_dp_cp_group,
)
return logits

Expand Down
Loading