Skip to content

Fix averaging for MoE z-loss metric tracking#3199

Open
Marks101 wants to merge 4 commits intoNVIDIA:mainfrom
Marks101:fix-zloss-tp-metric-tracking
Open

Fix averaging for MoE z-loss metric tracking#3199
Marks101 wants to merge 4 commits intoNVIDIA:mainfrom
Marks101:fix-zloss-tp-metric-tracking

Conversation

@Marks101
Copy link
Copy Markdown

@Marks101 Marks101 commented Feb 2, 2026

What does this PR do ?

At the moment there is no aggregation of MoE z-loss for metric tracking between ranks. The call to save_to_aux_losses_tracker() specifies neither reduce_group nor avg_group. In our understanding this metric should be averaged among tp, cp and dp groups.

Before #2095 all metric actually have been averaged per default along tp and cp groups, but even then there was no aggregation for tp for MoE z-loss.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Marks101 Marks101 requested review from a team as code owners February 2, 2026 13:18
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Feb 2, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team February 2, 2026 13:19
@yaox12 yaox12 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Feb 3, 2026
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Feb 4, 2026
@dimapihtar
Copy link
Copy Markdown
Contributor

/ok to test a0177b6

Markus Schnös added 2 commits February 5, 2026 10:59
@yaox12 yaox12 requested a review from Victarry March 3, 2026 02:04
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Mar 21, 2026
@ilml
Copy link
Copy Markdown
Contributor

ilml commented Apr 10, 2026

/ok to test 516e6f9

@chtruong814 chtruong814 added needs-follow-up Issue needs follow-up and removed needs-follow-up Issue needs follow-up labels Apr 10, 2026
@yaox12 yaox12 removed their request for review April 13, 2026 06:48
@chtruong814 chtruong814 added needs-follow-up Issue needs follow-up and removed needs-follow-up Issue needs follow-up labels Apr 17, 2026
@Phlip79 Phlip79 removed the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Apr 20, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added waiting-on-maintainers Waiting on maintainers to respond and removed needs-follow-up Issue needs follow-up labels Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants