Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 12, 2026

Addresses code review feedback from PR #490 regarding non-standard import patterns and unused variables.

Changes

  • Module imports: Removed .js extension from ElnStyles imports across 6 files

    • Changed import styles from "@site/src/components/eln/ElnStyles.js" to import styles from "@site/src/components/eln/ElnStyles"
    • Aligns with standard ES module import conventions
  • Unused state: Removed error state variable from ElnFinder and ElnFinderPharm

    • State was set in catch blocks but never read
    • Error logging remains via console.error()

Files modified:

  • ElnFinder.js, ElnFinderPharm.js, ElnCard.js
  • elnFilter/ElnFilter.js, elnFilter/FilterButton.js, elnFilter/TextSearch.js

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: jliermann <40795855+jliermann@users.noreply.github.com>
@jliermann jliermann marked this pull request as ready for review January 12, 2026 16:51
@jliermann jliermann merged commit 1344088 into localisation Jan 12, 2026
1 check passed
Copilot AI changed the title [WIP] Reorganize CSS architecture and standardize className handling Remove .js extensions from module imports and unused error state Jan 12, 2026
Copilot AI requested a review from jliermann January 12, 2026 16:52
Copilot stopped work on behalf of jliermann due to an error January 12, 2026 16:52
@jliermann jliermann deleted the copilot/sub-pr-490 branch January 16, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants