Localisation #490

jliermann · 2026-01-12T16:37:46Z

No description provided.

…ton components

refactor: classnames in camelcase for better code readability refactor: classnames in camelcase for better code readability refactor: classnames in camelcase for better code readability

…ment

Misc. fixes and refactoring of CSS

Copilot

Pull request overview

This pull request reorganizes the CSS architecture by centralizing CSS modules from component directories into a dedicated src/css/ folder. The changes also standardize className handling using the clsx utility instead of string concatenation, and apply consistent code formatting throughout.

Changes:

Centralized CSS modules from component folders to src/css/ directory
Updated all component imports to reference new CSS locations
Replaced string concatenation for className props with clsx utility
Applied consistent code formatting (spacing, indentation)

Reviewed changes

Copilot reviewed 30 out of 39 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/pages/index.js	Updated to use clsx for className combinations
src/css/*.module.css	New centralized CSS module files for various components
src/css/deprecated.css	Moved deprecated CSS styles to separate file
src/components/repos/RepoButton.js	Updated CSS import path and applied clsx
src/components/repos/DecisionTree.js	Updated CSS import path and reformatted
src/components/lbe/*.js	Updated CSS import paths to centralized location
src/components/eln/*.js	Updated to use ElnStyles.js wrapper for combined styles
src/components/eln/ElnStyles.js	New wrapper combining ELN and LBE styles
src/components/eln/Eln.module.css	Deleted - moved to src/css/Eln.module.css
src/components/commons/*.js	Updated CSS import paths
src/components/chemotion/*.js	Updated CSS import paths and reformatted
src/components/*.js	Updated to use clsx and new CSS paths
src/components/deprecated/*.js	New deprecated components directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T16:41:11Z

src/components/eln/ElnFinderPharm.js

 import ElnStack from "./ElnStack";

-import styles from "./Eln.module.css";
+import styles from "@site/src/components/eln/ElnStyles.js";


The import path includes the .js extension for ElnStyles. This is inconsistent with typical module import patterns and should be verified to work correctly.

Suggested change

import styles from "@site/src/components/eln/ElnStyles.js";

import styles from "@site/src/components/eln/ElnStyles";

Copilot · 2026-01-12T16:41:12Z

src/components/eln/ElnFinder.js


-import styles from "./Eln.module.css";
-
+import styles from "@site/src/components/eln/ElnStyles.js";


The import path includes the .js extension for ElnStyles. This pattern should be verified to work correctly with your build configuration.

Suggested change

import styles from "@site/src/components/eln/ElnStyles.js";

import styles from "@site/src/components/eln/ElnStyles";

Copilot · 2026-01-12T16:41:12Z

src/components/eln/elnFilter/TextSearch.js

@@ -1,38 +1,38 @@
-import styles from "../Eln.module.css";
+import styles from "@site/src/components/eln/ElnStyles.js";


The import path for ElnStyles.js should use a .js extension, but the file exports a default object, not a module. JavaScript/ES modules should not include the .js extension when importing from the same project, especially when importing a styles object. Consider changing the import to use the module path without the extension, or verify that this import works correctly in your build system.

Suggested change

import styles from "@site/src/components/eln/ElnStyles.js";

import styles from "@site/src/components/eln/ElnStyles";

Copilot · 2026-01-12T16:41:13Z

src/components/eln/elnFilter/FilterButton.js

@@ -1,32 +1,31 @@
+import styles from "@site/src/components/eln/ElnStyles.js";


The import path includes the .js extension for a module that exports styles. This is inconsistent with how CSS modules are typically imported. The same issue exists in FilterButton.js, ElnFilter.js, ElnCard.js, ElnFinderPharm.js, and ElnFinder.js. Consider removing the .js extension or verifying that your build configuration supports this pattern.

Suggested change

import styles from "@site/src/components/eln/ElnStyles.js";

import styles from "@site/src/components/eln/ElnStyles";

Copilot · 2026-01-12T16:41:13Z

src/components/eln/elnFilter/ElnFilter.js

 import FilterButton from "./FilterButton";

-import styles from "../Eln.module.css";
+import styles from "@site/src/components/eln/ElnStyles.js";


The import path includes the .js extension for ElnStyles, which is inconsistent with standard CSS module imports. This pattern is repeated across multiple ELN-related files and should be verified to work correctly with your build system.

Suggested change

import styles from "@site/src/components/eln/ElnStyles.js";

import styles from "@site/src/components/eln/ElnStyles";

Copilot · 2026-01-12T16:41:13Z

src/components/eln/ElnCard.js

 import ShortenDesc from "../commons/ShortenDesc.js";

-import styles from "./Eln.module.css";
+import styles from "@site/src/components/eln/ElnStyles.js";


The import path includes the .js extension for ElnStyles. Verify this works correctly with your build configuration, as this is an unusual pattern for importing a styles object from a JavaScript module that re-exports CSS modules.

Suggested change

import styles from "@site/src/components/eln/ElnStyles.js";

import styles from "@site/src/components/eln/ElnStyles";

Copilot · 2026-01-12T16:41:14Z

src/components/eln/ElnFinder.js

-        props.subDisc ? { subDisc: props.subDisc } : {}
-    );
+  const [elnData, setElnData] = useState(null);
+  const [error, setError] = useState(null);


Unused variable error.

Copilot · 2026-01-12T16:41:14Z

src/components/eln/ElnFinderPharm.js

-    const [elnData, setElnData] = useState(null);
-    const [error, setError] = useState(null);
+  const [elnData, setElnData] = useState(null);
+  const [error, setError] = useState(null);


Unused variable error.

jliermann · 2026-01-12T16:45:09Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-01-12T16:45:19Z

@jliermann I've opened a new pull request, #491, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: jliermann <40795855+jliermann@users.noreply.github.com>

[WIP] Reorganize CSS architecture and standardize className handling

jliermann added 19 commits January 12, 2026 13:18

chore: format

8ea0011

chore: styles

574a598

feat: refactor styles import to include required lbe classes

79ca5ac

chore: styles

735fa63

chore: formatting

b3a6de3

fix: update styles import and class names in FilterButton and RepoBut…

6fe181a

…ton components

chore: formatting

c8af244

feat: add styles for authorTrigger button in ShortenDesc component

bf73d24

chore: formatting

9b390a8

refactor: classnames in camelcase for better code readability

d6d4fb8

refactor: classnames in camelcase for better code readability refactor: classnames in camelcase for better code readability refactor: classnames in camelcase for better code readability

fix: improve alignment

63137b8

chore: formatting

c905dbe

refactor: replace string concatenation with clsx for className manage…

5364e5f

…ment

chore: deprecate currently unused components

3fefe97

chore: move deprecated methods table styles to a separate file

7a2ee60

refactor: move all css files to css folder

479d07d

chore: formatting

30ee3ba

refactor: all css imports pointed to css folder

6a2afa5

Merge pull request #489 from jliermann/main

73ddaf9

Misc. fixes and refactoring of CSS

jliermann requested a review from Copilot January 12, 2026 16:37

Copilot started reviewing on behalf of jliermann January 12, 2026 16:38 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

Initial plan

9e58843

Copilot AI mentioned this pull request Jan 12, 2026

Remove .js extensions from module imports and unused error state #491

Merged

Copilot AI and others added 2 commits January 12, 2026 16:48

Remove .js extensions from ElnStyles imports and fix unused variables

dca727a

Co-authored-by: jliermann <40795855+jliermann@users.noreply.github.com>

Merge pull request #491 from NFDI4Chem/copilot/sub-pr-490

1344088

[WIP] Reorganize CSS architecture and standardize className handling

jliermann merged commit 8ce587e into main Jan 12, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Localisation #490

Localisation #490

Uh oh!

jliermann commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

jliermann commented Jan 12, 2026

Uh oh!

Copilot AI commented Jan 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	import styles from "@site/src/components/eln/ElnStyles.js";
	import styles from "@site/src/components/eln/ElnStyles";


		import styles from "./Eln.module.css";

		import styles from "@site/src/components/eln/ElnStyles.js";

		@@ -1,38 +1,38 @@
		import styles from "../Eln.module.css";
		import styles from "@site/src/components/eln/ElnStyles.js";

		@@ -1,32 +1,31 @@
		import styles from "@site/src/components/eln/ElnStyles.js";

Localisation #490

Localisation #490

Uh oh!

Conversation

jliermann commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

jliermann commented Jan 12, 2026

Uh oh!

Copilot AI commented Jan 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants