Skip to content

Add three new CVMix parameters#392

Merged
alperaltuntas merged 3 commits intoNCAR:dev/ncarfrom
mnlevy1981:more_cvmix_updates
Oct 22, 2025
Merged

Add three new CVMix parameters#392
alperaltuntas merged 3 commits intoNCAR:dev/ncarfrom
mnlevy1981:more_cvmix_updates

Conversation

@mnlevy1981
Copy link
Collaborator

CVMix moved three hard-coded fortran parameters to user-defined parameters than can be set via cvmix_init_kpp(). This PR allows users to set those three parameters via MOM_input / MOM_override, but the MOM6 default values match the CVMix default values (which match the previously-hardcoded values)

Note that this requires the code in CVMix/CVMix-src#109 to build / run; I will accept that PR, push it to https://github.com/mom-ocean/CVMix-src, and update the external in this PR once testing is complete.

Testing: I am running pr_mom; one test has already completed and it is bit-for-bit (as expected). I will add a comment when the rest of the test suite finishes.

CVMix moved three hard-coded fortran parameters to user-defined parameters than
can be set via cvmix_init_kpp(). This PR allows users to set those three
parameters via MOM_input / MOM_override, but the MOM6 default values match the
CVMix default values (which match the previously-hardcoded values)
@mnlevy1981
Copy link
Collaborator Author

The pr_mom tests all pass (run successfully, and are bit-for-bit with head of dev/ncar):

71	PASS
	5	RUN (PASS)
      1 DIMCSL_Ld1.TL319_t232.G_JRA.derecho_intel.mom-cfc_mods
      1 ERI.TL319_t232.G_JRA.derecho_intel.mom-debug
      1 ERS.TL319_t232_wg37.GW_JRA.derecho_intel
      1 SMS_D.TL319_t232.G_JRA_RYF.derecho_intel
      1 SMS_Ld2.ne30pg3_t232.B1850C_LTso.derecho_intel
	5	BASELINE (PASS)
      1 DIMCSL_Ld1.TL319_t232.G_JRA.derecho_intel.mom-cfc_mods
      1 ERI.TL319_t232.G_JRA.derecho_intel.mom-debug
      1 ERS.TL319_t232_wg37.GW_JRA.derecho_intel
      1 SMS_D.TL319_t232.G_JRA_RYF.derecho_intel
      1 SMS_Ld2.ne30pg3_t232.B1850C_LTso.derecho_intel
0	BFAIL
0	CFAIL
0	SFAIL
0	FAIL

The github actions tests should pass once I update the CVMix submodule, which I will do after @gustavo-marques and I review both this PR and the one in CVMix.

Need updated CVMix API that includes ER_Cb, ER_Cs, and ER_Cu arguments to
CVMix_init_kpp()
The comments describing the new variables of the KPP_Cs class were "!" not "!<"
so doxygen didn't recognize them
@mnlevy1981 mnlevy1981 marked this pull request as ready for review October 20, 2025 14:55
@mnlevy1981
Copy link
Collaborator Author

Assuming the CI tests all pass, this is ready to be merged

@alperaltuntas alperaltuntas merged commit f4ba485 into NCAR:dev/ncar Oct 22, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants