Add three new CVMix parameters#392
Merged
alperaltuntas merged 3 commits intoNCAR:dev/ncarfrom Oct 22, 2025
Merged
Conversation
CVMix moved three hard-coded fortran parameters to user-defined parameters than can be set via cvmix_init_kpp(). This PR allows users to set those three parameters via MOM_input / MOM_override, but the MOM6 default values match the CVMix default values (which match the previously-hardcoded values)
Collaborator
Author
|
The The github actions tests should pass once I update the CVMix submodule, which I will do after @gustavo-marques and I review both this PR and the one in CVMix. |
gustavo-marques
approved these changes
Oct 17, 2025
Need updated CVMix API that includes ER_Cb, ER_Cs, and ER_Cu arguments to CVMix_init_kpp()
The comments describing the new variables of the KPP_Cs class were "!" not "!<" so doxygen didn't recognize them
Collaborator
Author
|
Assuming the CI tests all pass, this is ready to be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CVMix moved three hard-coded fortran parameters to user-defined parameters than can be set via cvmix_init_kpp(). This PR allows users to set those three parameters via MOM_input / MOM_override, but the MOM6 default values match the CVMix default values (which match the previously-hardcoded values)
Note that this requires the code in CVMix/CVMix-src#109 to build / run; I will accept that PR, push it to https://github.com/mom-ocean/CVMix-src, and update the external in this PR once testing is complete.
Testing: I am running
pr_mom; one test has already completed and it is bit-for-bit (as expected). I will add a comment when the rest of the test suite finishes.