Closed
Conversation
* Introduced three new parameters: - ER_Cb: TKE buoyancy production weight - ER_Cs: TKE Stokes production weight - ER_Cu: TKE shear production weight * Added default values based on Eq. 17 from Large et al. (2021). * Updated KPP_init to read these parameters from MOM_input and pass them to CVMix_kpp.
Collaborator
Author
|
@mnlevy1981, I confirmed that I get b4b with this PR. Please update CVmix with your latest changes. |
Collaborator
Author
|
This is being done in #392. Apologies to @mnlevy1981 for overlooking your pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added default values based on Eq. 17 from Large et al. (2021).
Updated KPP_init to read these parameters from MOM_input and pass them to CVMix_kpp.
Addresses #108
This PR does not change answers.