Exception support#16
Draft
iBicha wants to merge 18 commits into
Draft
Conversation
- Update duktape to 2.7.0 - Update build to be done with emcmake - Fix a couple of brightscript warnings in runtime.brs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exception support - depends on #15 and closes #12
See diff iBicha/wasm2brs@feature/remove-submodules...iBicha:wasm2brs:feature/exception-support
Added expressions needed to support exceptions
The basic exception tests are now passing.
The big hurdle that is left: We can't define labels inside a
Tryblock. That causes a Brightscript compilation error.So now we need to figure out how to avoid labels inside try blocks.
Perhaps:
I still don't know