[Part 2] Remove submodules, update tooling and samples#15
Conversation
|
@TrevorSundberg can you advise? I've taken steps to try and update the repo, but I've broken a few things in the process.
I'm fairly new to wasm ecosystem and I haven't spent enough time on it, so any help is appreciated, thanks |
|
Let me pull what you have tomorrow and then advise from there. I'm in Taiwan right working hard on my game (in Unity :P) and will get back to you when I get some time! |
- Update duktape to 2.7.0 - Update build to be done with emcmake - Fix a couple of brightscript warnings in runtime.brs
|
I made some progress on the topic; I did go the route of the tests at first, so I pulled the test suite, and followed closely the diff with the fork WebAssembly/testsuite@main...MotleyCoderDev:testsuite:master to figure out what broke - but most things didn't break according to the test. I went back to the older version, fixed what was broken and built the javascript sample into a .wasm, and then brought the wasm into the newer version of wasm2brs. Then it worked! I realized later that something drastically changed between wasi-sdk versions, because not only the javascript wasm was no longer running correctly, but it was also about 8x larger in size (about 400kb to about 3 mb) and that was normal. I was going to investigate this path, then I remembered that even the latest wasi-sdk doesn't support exceptions, which is what I'm trying to achieve in the first place. So I dropped that, and tried to build using emscripten. Lo and behold, the js sample is working again, and at a reasonable size again. With that in mind, I think this PR is fairly ready. Which opened up room for me to start looking into #16 |
Follow up to #14 (contains its changes, because it branches from it)
Diff iBicha/wasm2brs@feature/update-dependencies...iBicha:wasm2brs:feature/remove-submodules
Removed wabt and binaryen
Updated docker
Update samples
wasm-optAssertion failed: startMap.count(span.start) == 0 (/src/src/wasm/wasm-debug.cpp: add: 415)wasm-optfrom binaryen v115, and I got hit byFunction $137 had 324 labels - Label limit reachedso something has changed in how wasm-sdk generates code I assume.wasm-ld: error: /tmp/mandelbrot-20f571.o: undefined symbol: memset