Repository navigation
Use the unused substitution example and set aside three duplicates - #102
Merged
d-morrison merged 1 commit intoNov 7, 2026
Merged
Conversation
The four proof-writing theorem files that #88 listed are already included from the equivalence-and-negation chapter, but four of the example files are not. Three of them reuse ids that the chapter's own examples carry (exm-distributive, exm-conditional-as-or, exm-negate-conditional), so including them would duplicate those ids. Those three move to chapters/outtakes/, which keeps their text. The fourth, exm-substitution-logic, has its own id and shows a case the chapter's example does not (combining double negation with substitution), so the chapter now includes it right after that example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
Contributor
|
Claude finished review — View run No dangling includes, and the working tree is clean beyond the review-diff artifact. No prior comments exist on the PR, so this is a first review pass. Review: PR #102 — Use the unused substitution example and set aside three duplicatesSummary: Resolves #88 (part of #60) by disposing of the four previously-unused example subfiles in
Verification performed:
No issues found. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "2574cbaee14f833ff2683027e80bd98c0c909137",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Checked chapters/equivalence-negation.qmd include ordering and chapters/outtakes renames for dangling references and id collisions; none found.",
"holistic_assessment": "Scope matches issue #88 exactly, integrates cleanly with the existing outtakes CI exclusion convention, and introduces no rendering or cross-reference regressions."
}Reviewed commit: 2574cba |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the substitution-example addition and preservation of duplicate-ID examples as outtakes.
No open issues 🎉
What changed in this PR
Resolves the unused-example decisions in #88 as part of the shared-math consolidation in #60. The chapter gains a distinct substitution example, while three examples with duplicate identifiers are preserved as outtakes.
Changes:
- Includes the double-negation substitution example after the chapter’s existing substitution example.
- Moves three duplicate-ID examples to
chapters/outtakes/, retaining their text without including them in the chapter.
| File | Description |
|---|---|
chapters/outtakes/_negate-conditional_exm.qmd |
Preserves the unused conditional-negation example. |
chapters/outtakes/_distributive_exm.qmd |
Preserves the unused distributive-law example. |
chapters/outtakes/_conditional-as-or_exm.qmd |
Preserves the unused conditional-as-disjunction example. |
chapters/equivalence-negation.qmd |
Includes the distinct substitution example with a slide break. |
Review effort: Balanced
Contributor
Built to branch |
Contributor
Author
|
I'm merging this under Ezra's Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
d-morrison
deleted the
claude/project-thread-aj2ep4-unused-proof-subfiles
branch
November 7, 2026 00:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88. Part of #60.
Four of the eight files #88 listed are the theorem files
_distributive_thm,_conditional-as-or_cor,_negate-conditional_thmand_substitution-logic_thm.chapters/equivalence-negation.qmdalready includes all four, so they are in use and stay where they are.The other four are unused examples:
_distributive_exm,_conditional-as-or_exmand_negate-conditional_exmreuse ids that the chapter's own examples inchapters/_subfiles/equivalence-negation/already carry. Including them would duplicate those ids, so they move tochapters/outtakes/, where their text is kept._substitution-logic_exm(#exm-substitution-logic) has its own id and covers something the chapter's#exm-substitutiondoes not, namely double negation combined with substitution. The chapter now includes it right after that example.Checked: I rendered
chapters/equivalence-negation.qmdto HTML. Quarto printed no warnings,exm-substitution-logicis on the page, and no reference is left unresolved (no?@on the page).Generated by Claude Code