Skip to content

rpkg-ci image: set RSTUDIO_PANDOC so R Markdown vignettes build - #1656

Merged
d-morrison merged 2 commits into
mainfrom
claude/project-thread-ewd82d
Nov 8, 2026
Merged

d-morrison merged 2 commits into
mainfrom
claude/project-thread-ewd82d

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Posted by Claude Code (AI agent) --- not written by a human.

Refs #1640. Infra-only change, no lecture content.

A cold R CMD check of Morrison-Lab/rampp on a cluster execute node, using rpkg-ci.sif with apptainer exec --containall, failed in R CMD build with "Pandoc is required to build R Markdown vignettes". The image's pandoc ships inside Quarto and is not on PATH. With RSTUDIO_PANDOC=/opt/quarto/bin/tools/x86_64 set by hand, the check finished with 0 errors, 0 warnings and 0 notes (HTCondor cluster 14452, 224 s).

  • condor-batch/image/rpkg-ci.def exports RSTUDIO_PANDOC in %environment, and the header comment no longer says R 4.5 (the image runs R 4.6.2).
  • Changelog fragment changelog.d/rpkg-ci-pandoc.fixed.md.

Not verified: the recipe change itself is not yet rebuilt; the rebuild on cf463-02 follows the merge. The run above set the variable on the command line.

Separate finding, not fixed here: pak failed inside the container even with a writable TMPDIR (tarball downloads from the PPM source URL), while remotes::install_deps() worked. The condor-batch consumer should use the latter or I will file a follow-up.


Generated by Claude Code

A cold R CMD check of rampp on a cluster node needed it set by hand (gha#1640).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9ovVGyLF8hg7XQbgAt
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9ovVGyLF8hg7XQbgAt
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR #1656 live just now. It is open, not a draft, and not merged (mergedAt is null). The head is 2645b0d4ef77a0d249b5933ff894d5b664ad9b87, the commit I reviewed, so the verdict below still applies.

My review of 2645b0d found no problems. The one gap is that I didn't download the Quarto package to confirm the pandoc binary sits at /opt/quarto/bin/tools/x86_64/pandoc.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "2645b0d4ef77a0d249b5933ff894d5b664ad9b87",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The RSTUDIO_PANDOC export in condor-batch/image/rpkg-ci.def points at Quarto's bundled tools directory under the deb install from lds-ci.def; the exact pandoc binary path was not downloaded and verified.",
  "holistic_assessment": "Small scoped fix with a changelog fragment, no permissions or workflow interface changes, no regression risk to other images, and live PR state confirms the open head matches the reviewed commit."
}

Reviewed commit: 2645b0d

Reviewed commit: 2645b0d

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.8269 (review) — run

@d-morrison
d-morrison merged commit a285112 into main Nov 8, 2026
159 checks passed
@d-morrison
d-morrison deleted the claude/project-thread-ewd82d branch November 8, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants