Repository navigation
rpkg-ci image: set RSTUDIO_PANDOC so R Markdown vignettes build - #1656
Merged
Merged
Conversation
A cold R CMD check of rampp on a cluster node needed it set by hand (gha#1640). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9ovVGyLF8hg7XQbgAt
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9ovVGyLF8hg7XQbgAt
Contributor
|
Claude finished review — View run I fetched PR #1656 live just now. It is open, not a draft, and not merged ( My review of VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "2645b0d4ef77a0d249b5933ff894d5b664ad9b87",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The RSTUDIO_PANDOC export in condor-batch/image/rpkg-ci.def points at Quarto's bundled tools directory under the deb install from lds-ci.def; the exact pandoc binary path was not downloaded and verified.",
"holistic_assessment": "Small scoped fix with a changelog fragment, no permissions or workflow interface changes, no regression risk to other images, and live PR state confirms the open head matches the reviewed commit."
}Reviewed commit: 2645b0d Reviewed commit: 2645b0d |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posted by Claude Code (AI agent) --- not written by a human.
Refs #1640. Infra-only change, no lecture content.
A cold
R CMD checkofMorrison-Lab/ramppon a cluster execute node, usingrpkg-ci.sifwithapptainer exec --containall, failed inR CMD buildwith "Pandoc is required to build R Markdown vignettes". The image's pandoc ships inside Quarto and is not onPATH. WithRSTUDIO_PANDOC=/opt/quarto/bin/tools/x86_64set by hand, the check finished with 0 errors, 0 warnings and 0 notes (HTCondor cluster 14452, 224 s).condor-batch/image/rpkg-ci.defexportsRSTUDIO_PANDOCin%environment, and the header comment no longer says R 4.5 (the image runs R 4.6.2).changelog.d/rpkg-ci-pandoc.fixed.md.Not verified: the recipe change itself is not yet rebuilt; the rebuild on cf463-02 follows the merge. The run above set the variable on the command line.
Separate finding, not fixed here:
pakfailed inside the container even with a writableTMPDIR(tarball downloads from the PPM source URL), whileremotes::install_deps()worked. The condor-batch consumer should use the latter or I will file a follow-up.Generated by Claude Code