Skip to content

ui: review round 2 (phone touch sizes and font size, one row style, Quick menu, All games scroll, TV re-fit, shared covers) - #102

Open
xservzeroman wants to merge 2 commits into
perf/ui-quickwinsfrom
ui/review-round2
Open

xservzeroman wants to merge 2 commits into
perf/ui-quickwinsfrom
ui/review-round2

Conversation

@xservzeroman

Copy link
Copy Markdown

UI review, round 2 (Saleh: "do 1 to 5").

Changelog

  1. Phones (Sw.touchFirst = no built-in controller): tabs, chips, Back and the settings groups use Sw.tap(), at least 48 dp tall. Sw.text follows Android's Font size (1-1.3x) on the NORMAL layout. Handhelds with controls (the Odin) are unchanged.
  2. One row style: listRow and optRow share ROW_ICON 72, ROW_ICON_R 18, title weight 700, subtitle gap lineGap, right value ROW_VALUE 24 in sw.sub.
  3. Quick menu (home/QuickMenu.kt): danger labels red on the handheld too; hints read A then B on both; the upright sheet's list is weighted, so hints stay on screen; TV rows minimumHeight 80 and wrap content instead of a fixed 80.
  4. All games: no elevation on grid tiles; All games keeps scrollY per tab and Home's row keeps scrollX across redraws (API 23+).
  5. TV: onConfigurationChanged recreates when width, height or density changed (the manifest keeps the activity through display changes). Covers in Tv.kt holds the cover palette and index used by both Tv.twoTone and Sw.ART/artIndex.

To test

  • A phone without a controller: tabs, chips, Back and settings groups are comfortably tappable; bigger system font size shows bigger text. The Odin looks as before.
  • Quick menu on the handheld: Quit game in red; A/B hint order.
  • All games with many games: scroll down, wait for a refresh (start a game on the PC): no jump to the top.
  • TV: change the TV's output resolution: MoonCast re-fits. A game without art has the same cover colour on the TV and the Odin.

🤖 Generated with Claude Code

…uick menu, All games scroll, TV re-fit and shared covers (test254)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hint bar (test255)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@xservzeroman

Copy link
Copy Markdown
Author

On-device review of test254 on the Odin (20 screens). Measured: cold start 327 ms; janky frames 0.6% along Home, 0.4% scrolling All games, 0.5% down the Settings groups (5-12 ms frames). Found and fixed in test255: lists drew under the hint bar (Consoles' Find my Xbox over the controller name) — the content area doesn't clip, so the scroll panes now sit in a clipping frame.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants