Repository navigation
ui: review round 2 (phone touch sizes and font size, one row style, Quick menu, All games scroll, TV re-fit, shared covers) - #102
Open
xservzeroman wants to merge 2 commits into
Open
xservzeroman wants to merge 2 commits into
xservzeroman wants to merge 2 commits into
Conversation
…uick menu, All games scroll, TV re-fit and shared covers (test254) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hint bar (test255) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
On-device review of test254 on the Odin (20 screens). Measured: cold start 327 ms; janky frames 0.6% along Home, 0.4% scrolling All games, 0.5% down the Settings groups (5-12 ms frames). Found and fixed in test255: lists drew under the hint bar (Consoles' Find my Xbox over the controller name) — the content area doesn't clip, so the scroll panes now sit in a clipping frame. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI review, round 2 (Saleh: "do 1 to 5").
Changelog
Sw.touchFirst= no built-in controller): tabs, chips, Back and the settings groups useSw.tap(), at least 48 dp tall.Sw.textfollows Android's Font size (1-1.3x) on the NORMAL layout. Handhelds with controls (the Odin) are unchanged.listRowandoptRowshareROW_ICON72,ROW_ICON_R18, title weight 700, subtitle gaplineGap, right valueROW_VALUE24 insw.sub.home/QuickMenu.kt): danger labels red on the handheld too; hints read A then B on both; the upright sheet's list is weighted, so hints stay on screen; TV rowsminimumHeight80 and wrap content instead of a fixed 80.elevationon grid tiles; All games keepsscrollYper tab and Home's row keepsscrollXacross redraws (API 23+).onConfigurationChangedrecreates when width, height or density changed (the manifest keeps the activity through display changes).CoversinTv.ktholds the cover palette and index used by bothTv.twoToneandSw.ART/artIndex.setOnScrollChangeListenerfixed with an API check). Stacked on perf(handheld): UI review quick wins (less rebuilding, caches, off-thread picker, a11y) #101.To test
🤖 Generated with Claude Code