Skip to content

chore(deps): update dependency node to v24 #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ham-renovate wants to merge 1 commit into from
Closed

chore(deps): update dependency node to v24 #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22.x
node-version: 24.x
cache: "pnpm"

- name: Install build dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22.x
node-version: 24.x

- name: Install Dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22.x
node-version: 24.x

- name: Install Dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-evault-core-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
Comment on lines 20 to +23
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Stale step name and inconsistent node-version format.

Two nits here:

  1. Step name (Line 20): The name: Set up Node.js 22 label was not updated alongside the version bump. It now misrepresents the runtime being installed.
  2. node-version format (Line 23): This file uses 24 (integer) while build.yml, check-code.yml, and check-format.yml use 24.x. Both resolve identically in actions/setup-node, but the inconsistency is confusing. Prefer the explicit semver-range form 24.x used in the other workflows.
✏️ Proposed fix 
-      - name: Set up Node.js 22
+      - name: Set up Node.js 24
         uses: actions/setup-node@v4
         with:
-          node-version: 24
+          node-version: 24.x
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/tests-evault-core-e2e.yml around lines 20 - 23, Update the
GitHub Actions step label and node version format: change the step name "Set up
Node.js 22" to "Set up Node.js 24" and change the actions/setup-node
`node-version` value from 24 to the semver format "24.x" so it matches other
workflows (locate the step using the name and the actions/setup-node
invocation).


- name: Install build dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-evault-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24

- name: Install build dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-registry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
Comment on lines 19 to +22
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Stale step name and inconsistent node-version format.

  1. Step name (Line 19): Set up Node.js 22 — needs updating to 24.
  2. node-version format (Line 22): Bare 24 instead of 24.x.
✏️ Proposed fix 
-            - name: Set up Node.js 22
+            - name: Set up Node.js 24
               uses: actions/setup-node@v4
               with:
-                  node-version: 24
+                  node-version: 24.x
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Set up Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
- name: Set up Node.js 24
uses: actions/setup-node@v4
with:
node-version: 24.x
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/tests-registry.yml around lines 19 - 22, Update the GitHub
Actions step that uses actions/setup-node@v4: change the step name "Set up
Node.js 22" to "Set up Node.js 24" and make the node-version value use the
semantic minor format "24.x" (update the node-version key under the
actions/setup-node@v4 step).


- name: Install build dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-w3id.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Set up Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24

- name: Install pnpm
run: npm install -g pnpm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-wallet-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Set up Node.js 22
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Stale step name after version bump.

The step name still reads Set up Node.js 22 while the actual version being installed is now 24. This produces misleading output in CI run logs.

✏️ Proposed fix 
-      - name: Set up Node.js 22
+      - name: Set up Node.js 24
         uses: actions/setup-node@v4
         with:
           node-version: 24
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Set up Node.js 22
- name: Set up Node.js 24
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/tests-wallet-sdk.yml at line 21, Update the GitHub Actions
step name to reflect the actual Node version being installed: rename the step
label "Set up Node.js 22" to "Set up Node.js 24" (or a semantically equivalent
label) so CI logs match the version implemented in the workflow file; locate and
edit the step name string in the workflow definition where "Set up Node.js 22"
appears.

uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24

- name: Install pnpm
run: npm install -g pnpm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-web3-adapter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24

- name: Install build dependencies
run: |
Expand Down