chore(deps): update dependency node to v24#868
Closed
ham-renovate wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
📝 WalkthroughWalkthroughBumped Node.js runtime version from 22.x to 24.x across nine GitHub Actions workflow files. Each workflow's setup-node step was updated identically with no changes to job steps, control flow, or logic. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
.github/workflows/tests-web3-adapter.yml (1)
17-22:⚠️ Potential issue | 🟡 MinorStale step name, inconsistent
node-versionformat, and outdatedactions/checkout.Three nits:
- Step name (Line 19):
Set up Node.js 22is now stale — should be updated to24.node-versionformat (Line 22): Uses integer24instead of the24.xsemver-range form used inbuild.yml,check-code.yml, andcheck-format.yml.actions/checkout@v3(Line 17): This file still pinscheckout@v3while all other workflows in this PR have already moved to@v4. This is pre-existing but now stands out clearly.✏️ Proposed fix
- uses: actions/checkout@v3 + uses: actions/checkout@v4 - - name: Set up Node.js 22 + - name: Set up Node.js 24 uses: actions/setup-node@v4 with: - node-version: 24 + node-version: 24.x🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tests-web3-adapter.yml around lines 17 - 22, Update the workflow step named "Set up Node.js 22" to reflect Node.js 24, change the node-version value from the integer 24 to the semver string "24.x" (key: node-version) to match other workflows, and update the checkout action reference from uses: actions/checkout@v3 to uses: actions/checkout@v4 to stay consistent with the rest of the repo..github/workflows/tests-evault-core.yml (1)
17-22:⚠️ Potential issue | 🟡 MinorStale step name, inconsistent
node-versionformat, and outdatedactions/checkout.Same pattern as
tests-web3-adapter.yml:
- Step name (Line 19):
Set up Node.js 22is stale.node-versionformat (Line 22): Bare integer24instead of24.x.actions/checkout@v3(Line 17): Pre-existing inconsistency with the rest of the repo's workflows.✏️ Proposed fix
- uses: actions/checkout@v3 + uses: actions/checkout@v4 - - name: Set up Node.js 22 + - name: Set up Node.js 24 uses: actions/setup-node@v4 with: - node-version: 24 + node-version: 24.x🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tests-evault-core.yml around lines 17 - 22, Update the workflow step names and inputs to match the repo conventions: rename the step labeled "Set up Node.js 22" to reflect the actual Node major (e.g., "Set up Node.js 24"), change the node-version value from the bare integer 24 to the semver string "24.x", and replace the actions/checkout@v3 usage with the repo-standard version (e.g., actions/checkout@v4) so the checkout action matches other workflows; adjust the step name, the node-version input, and the actions/checkout ref in the .github/workflows/tests-evault-core.yml file accordingly..github/workflows/tests-w3id.yml (1)
19-24:⚠️ Potential issue | 🟡 MinorStale step name, inconsistent
node-versionformat, and outdatedactions/checkout.Same pattern as
tests-evault-core.ymlandtests-web3-adapter.yml:
- Step name (Line 21):
Set up Node.js 22is stale.node-versionformat (Line 24): Bare24instead of24.x.actions/checkout@v3(Line 19): Pre-existing inconsistency with the rest of the repo.✏️ Proposed fix
- uses: actions/checkout@v3 + uses: actions/checkout@v4 - - name: Set up Node.js 22 + - name: Set up Node.js 24 uses: actions/setup-node@v4 with: - node-version: 24 + node-version: 24.x🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tests-w3id.yml around lines 19 - 24, Update the workflow step and checkout action to match repo conventions: rename the step title "Set up Node.js 22" to "Set up Node.js 24", change the node-version value from the bare number 24 to the semver string "24.x", and update actions/checkout@v3 to actions/checkout@v4 so it matches the other workflows and uses the latest checkout action.
🧹 Nitpick comments (1)
.github/workflows/tests-wallet-sdk.yml (1)
24-24: Node.js 24 is valid Active LTS — verify breaking changes in wallet-sdk.Node.js 22.x moved to Maintenance LTS on 2025-10-21 and Node.js 24.x became the Active LTS on 2025-10-28, making this upgrade well-timed.
However, Node.js 24 ships with meaningful runtime changes that are particularly relevant to a cryptographic package like
wallet-sdk:
- Node.js 24 uses OpenSSL 3.5 with a default security level of 2, enforcing higher cryptographic standards — keys shorter than 2048 bits (RSA/DSA/DH) and 224 bits (ECC) are prohibited, and RC4-based cipher suites are no longer permitted.
- Many APIs now include improved argument and option validation: Buffer APIs now throw when attempting to write beyond their length;
fs.symlink()and timers APIs enforce stricter type validation; and invalid inputs tofs.existsSync()now trigger runtime warnings.Confirm that the
wallet-sdktest suite passes cleanly under Node.js 24, especially for any cryptographic key generation or signing operations.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tests-wallet-sdk.yml at line 24, Update CI verification to ensure wallet-sdk works on Node.js 24: run the full test matrix with node-version: 24 and confirm all unit/integration tests—especially cryptographic flows (key generation, signing, verification) in modules like any Wallet.createKey / Wallet.sign / CryptoUtils.generateKey—pass without errors; if failures occur, run the test suite locally under Node 24, capture stack traces, and fix issues related to OpenSSL 3.5 restrictions (key sizes/cipher changes) and stricter runtime validations (Buffer, fs, timers) before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/tests-evault-core-e2e.yml:
- Around line 20-23: Update the GitHub Actions step label and node version
format: change the step name "Set up Node.js 22" to "Set up Node.js 24" and
change the actions/setup-node `node-version` value from 24 to the semver format
"24.x" so it matches other workflows (locate the step using the name and the
actions/setup-node invocation).
In @.github/workflows/tests-registry.yml:
- Around line 19-22: Update the GitHub Actions step that uses
actions/setup-node@v4: change the step name "Set up Node.js 22" to "Set up
Node.js 24" and make the node-version value use the semantic minor format "24.x"
(update the node-version key under the actions/setup-node@v4 step).
In @.github/workflows/tests-wallet-sdk.yml:
- Line 21: Update the GitHub Actions step name to reflect the actual Node
version being installed: rename the step label "Set up Node.js 22" to "Set up
Node.js 24" (or a semantically equivalent label) so CI logs match the version
implemented in the workflow file; locate and edit the step name string in the
workflow definition where "Set up Node.js 22" appears.
---
Outside diff comments:
In @.github/workflows/tests-evault-core.yml:
- Around line 17-22: Update the workflow step names and inputs to match the repo
conventions: rename the step labeled "Set up Node.js 22" to reflect the actual
Node major (e.g., "Set up Node.js 24"), change the node-version value from the
bare integer 24 to the semver string "24.x", and replace the actions/checkout@v3
usage with the repo-standard version (e.g., actions/checkout@v4) so the checkout
action matches other workflows; adjust the step name, the node-version input,
and the actions/checkout ref in the .github/workflows/tests-evault-core.yml file
accordingly.
In @.github/workflows/tests-w3id.yml:
- Around line 19-24: Update the workflow step and checkout action to match repo
conventions: rename the step title "Set up Node.js 22" to "Set up Node.js 24",
change the node-version value from the bare number 24 to the semver string
"24.x", and update actions/checkout@v3 to actions/checkout@v4 so it matches the
other workflows and uses the latest checkout action.
In @.github/workflows/tests-web3-adapter.yml:
- Around line 17-22: Update the workflow step named "Set up Node.js 22" to
reflect Node.js 24, change the node-version value from the integer 24 to the
semver string "24.x" (key: node-version) to match other workflows, and update
the checkout action reference from uses: actions/checkout@v3 to uses:
actions/checkout@v4 to stay consistent with the rest of the repo.
---
Nitpick comments:
In @.github/workflows/tests-wallet-sdk.yml:
- Line 24: Update CI verification to ensure wallet-sdk works on Node.js 24: run
the full test matrix with node-version: 24 and confirm all unit/integration
tests—especially cryptographic flows (key generation, signing, verification) in
modules like any Wallet.createKey / Wallet.sign / CryptoUtils.generateKey—pass
without errors; if failures occur, run the test suite locally under Node 24,
capture stack traces, and fix issues related to OpenSSL 3.5 restrictions (key
sizes/cipher changes) and stricter runtime validations (Buffer, fs, timers)
before merging.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.github/workflows/build.yml.github/workflows/check-code.yml.github/workflows/check-format.yml.github/workflows/tests-evault-core-e2e.yml.github/workflows/tests-evault-core.yml.github/workflows/tests-registry.yml.github/workflows/tests-w3id.yml.github/workflows/tests-wallet-sdk.yml.github/workflows/tests-web3-adapter.yml
Comment on lines
20
to
+23
| - name: Set up Node.js 22 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 |
Contributor
There was a problem hiding this comment.
Stale step name and inconsistent node-version format.
Two nits here:
- Step name (Line 20): The
name: Set up Node.js 22label was not updated alongside the version bump. It now misrepresents the runtime being installed. node-versionformat (Line 23): This file uses24(integer) whilebuild.yml,check-code.yml, andcheck-format.ymluse24.x. Both resolve identically inactions/setup-node, but the inconsistency is confusing. Prefer the explicit semver-range form24.xused in the other workflows.
✏️ Proposed fix
- - name: Set up Node.js 22
+ - name: Set up Node.js 24
uses: actions/setup-node@v4
with:
- node-version: 24
+ node-version: 24.x🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/tests-evault-core-e2e.yml around lines 20 - 23, Update the
GitHub Actions step label and node version format: change the step name "Set up
Node.js 22" to "Set up Node.js 24" and change the actions/setup-node
`node-version` value from 24 to the semver format "24.x" so it matches other
workflows (locate the step using the name and the actions/setup-node
invocation).
Comment on lines
19
to
+22
| - name: Set up Node.js 22 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 |
Contributor
There was a problem hiding this comment.
Stale step name and inconsistent node-version format.
- Step name (Line 19):
Set up Node.js 22— needs updating to24. node-versionformat (Line 22): Bare24instead of24.x.
✏️ Proposed fix
- - name: Set up Node.js 22
+ - name: Set up Node.js 24
uses: actions/setup-node@v4
with:
- node-version: 24
+ node-version: 24.x📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - name: Set up Node.js 22 | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: 22 | |
| node-version: 24 | |
| - name: Set up Node.js 24 | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: 24.x |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/tests-registry.yml around lines 19 - 22, Update the GitHub
Actions step that uses actions/setup-node@v4: change the step name "Set up
Node.js 22" to "Set up Node.js 24" and make the node-version value use the
semantic minor format "24.x" (update the node-version key under the
actions/setup-node@v4 step).
| @@ -21,7 +21,7 @@ jobs: | |||
| - name: Set up Node.js 22 | |||
Contributor
There was a problem hiding this comment.
Stale step name after version bump.
The step name still reads Set up Node.js 22 while the actual version being installed is now 24. This produces misleading output in CI run logs.
✏️ Proposed fix
- - name: Set up Node.js 22
+ - name: Set up Node.js 24
uses: actions/setup-node@v4
with:
node-version: 24📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - name: Set up Node.js 22 | |
| - name: Set up Node.js 24 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/tests-wallet-sdk.yml at line 21, Update the GitHub Actions
step name to reflect the actual Node version being installed: rename the step
label "Set up Node.js 22" to "Set up Node.js 24" (or a semantically equivalent
label) so CI logs match the version implemented in the workflow file; locate and
edit the step name string in the workflow definition where "Set up Node.js 22"
appears.
Collaborator
Author
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
22→2422.x→24.xRelease Notes
actions/node-versions (node)
v24.0.0: 24.0.0Compare Source
Node.js 24.0.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.