Conversation
hmalik88
commented
Dec 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 94.59% 94.71% +0.11%
==========================================
Files 494 497 +3
Lines 10656 10802 +146
Branches 1635 1649 +14
==========================================
+ Hits 10080 10231 +151
+ Misses 576 571 -5 ☔ View full report in Codecov by Sentry. |
packages/snaps-rpc-methods/src/permitted/scheduleBackgroundEvent.ts
Outdated
Show resolved
Hide resolved
Mrtenz
previously requested changes
Dec 17, 2024
packages/snaps-controllers/src/cronjob/CronjobController.test.ts
Outdated
Show resolved
Hide resolved
packages/snaps-rpc-methods/src/permitted/scheduleBackgroundEvent.ts
Outdated
Show resolved
Hide resolved
packages/snaps-rpc-methods/src/permitted/scheduleBackgroundEvent.ts
Outdated
Show resolved
Hide resolved
packages/snaps-rpc-methods/src/permitted/scheduleBackgroundEvent.ts
Outdated
Show resolved
Hide resolved
packages/snaps-rpc-methods/src/permitted/scheduleBackgroundEvent.ts
Outdated
Show resolved
Hide resolved
FrederikBolding
previously approved these changes
Dec 17, 2024
Member
|
LGTM once @Mrtenz approves it as well |
Mrtenz
previously approved these changes
Dec 19, 2024
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Mrtenz
approved these changes
Dec 19, 2024
FrederikBolding
added a commit
that referenced
this pull request
Jan 10, 2025
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
This PR adds a new feature: background events, per [SIP-28](https://github.com/MetaMask/SIPs/blob/main/SIPS/sip-28.md). A summary of the changes made: 1. The `CronjobController` was updated to now include logic for handling and storing background events. 2. `snap_scheduleBackgroundEvent` RPC method was added to schedule an event. 3. `snap_cancelBackgroundEvent` RPC method was added to cancel an event. 4. `snap_getBackgroundEvents` RPC method was added to get a snap's background events (not outlined in the SIP, but will be added as an addendum soon).
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature: background events, per SIP-28. A summary of the changes made:
CronjobControllerwas updated to now include logic for handling and storing background events.snap_scheduleBackgroundEventRPC method was added to schedule an event.snap_cancelBackgroundEventRPC method was added to cancel an event.snap_getBackgroundEventsRPC method was added to get a snap's background events (not outlined in the SIP, but will be added as an addendum soon).