fix: Make jobs property fully optional in the cronjob endowment#3005
Merged
FrederikBolding merged 1 commit intomainfrom Jan 10, 2025
Merged
fix: Make jobs property fully optional in the cronjob endowment#3005FrederikBolding merged 1 commit intomainfrom
jobs property fully optional in the cronjob endowment#3005FrederikBolding merged 1 commit intomainfrom
Conversation
FrederikBolding
force-pushed
the
fb/make-cronjobs-fully-optional
branch
from
1fd8ce1 to
7525e12
Compare
Mrtenz
approved these changes
Jan 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 497 497
Lines 10826 10826
Branches 1654 1654
=======================================
Hits 10255 10255
Misses 571 571 ☔ View full report in Codecov by Sentry. |
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the
jobsproperty fully optional in the cronjob endowment since it is also allowed to be empty.We accounted for and discussed this in #2941, but must have forgotten to allow
endowment:cronjob: {}.