Skip to content

test: update documentation after renaming connect-monorepo to metamask-connect#41829

Open
ffmcgee725 wants to merge 1 commit into
mainfrom
jc/WAPI-1255
Open

test: update documentation after renaming connect-monorepo to metamask-connect#41829
ffmcgee725 wants to merge 1 commit into
mainfrom
jc/WAPI-1255

Conversation

@ffmcgee725

@ffmcgee725 ffmcgee725 commented Apr 16, 2026

Copy link
Copy Markdown
Member

Description

Updates a repo name reference from connect-monorepo to metamask-connect in an e2e page object comment, ahead of the GitHub repo rename from MetaMask/connect-monorepo to MetaMask/metamask-connect.

File Change
test/e2e/page-objects/pages/test-dapp-mm-connect.ts Comment: Repo: metamask/connect-monorepometamask/metamask-connect

No functional or behavioral changes — this is a comment-only update.

Changelog

CHANGELOG entry: null

Related issues

Manual testing steps

No manual testing required — comment-only change with no runtime impact.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Comment-only change with no functional impact or code-path modifications.

Overview
Updates the TestDappMmConnect e2e page-object header comment to reflect the repo rename from metamask/connect-monorepo to metamask/metamask-connect.

No runtime/test behavior changes; this is documentation-only.

Reviewed by Cursor Bugbot for commit 572679c. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamaskbotv2

metamaskbotv2 Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (1 files, +1 -1)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 pages/
          • 📄 test-dapp-mm-connect.ts +1 -1

@metamaskbotv2

metamaskbotv2 Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor
Builds ready [572679c] [reused from 2b39db2]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 11 warn · 🔴 2 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24504071699 | Baseline logs

Metricschrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
importSrpHome🔴 [logs]
swap🔴 [logs]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-browserify
loadNewAccount🟡 [Show logs]
confirmTx🟡 [Show logs]
bridgeUserActions🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -23%
  • loadNewAccount/total: -23%
  • bridgeUserActions/bridge_load_asset_picker: -50%
  • bridgeUserActions/total: -14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.5s
  • 🟡 confirmTx/FCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
startupStandardHome🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]
startupPowerUserHome🟡 [Show logs]🟡 [Show logs]🟡 [Show logs]🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -23%
  • startupStandardHome/load: -12%
  • startupStandardHome/domContentLoaded: -14%
  • startupStandardHome/backgroundConnect: +12%
  • startupStandardHome/firstReactRender: -18%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/loadScripts: -17%
  • startupStandardHome/numNetworkReqs: -37%
  • startupPowerUserHome/uiStartup: -24%
  • startupPowerUserHome/backgroundConnect: +90%
  • startupPowerUserHome/firstReactRender: -11%
  • startupPowerUserHome/setupStore: -12%
  • startupPowerUserHome/numNetworkReqs: -53%
  • startupStandardHome/uiStartup: -22%
  • startupStandardHome/load: -17%
  • startupStandardHome/domContentLoaded: -17%
  • startupStandardHome/firstPaint: -11%
  • startupStandardHome/backgroundConnect: -37%
  • startupStandardHome/firstReactRender: -27%
  • startupStandardHome/loadScripts: -17%
  • startupStandardHome/setupStore: -20%
  • startupStandardHome/numNetworkReqs: -44%
  • startupPowerUserHome/uiStartup: -28%
  • startupStandardHome/uiStartup: -12%
  • startupStandardHome/domInteractive: -56%
  • startupStandardHome/backgroundConnect: +11%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/setupStore: +13%
  • startupStandardHome/numNetworkReqs: -34%
  • startupPowerUserHome/uiStartup: -32%
  • startupPowerUserHome/backgroundConnect: -31%
  • startupPowerUserHome/setupStore: +55%
  • startupStandardHome/uiStartup: -31%
  • startupStandardHome/load: -25%
  • startupStandardHome/domContentLoaded: -25%
  • startupStandardHome/domInteractive: -69%
  • startupStandardHome/backgroundConnect: -15%
  • startupStandardHome/firstReactRender: -18%
  • startupStandardHome/initialActions: -43%
  • startupStandardHome/loadScripts: -25%
  • startupStandardHome/setupStore: -50%
  • startupStandardHome/numNetworkReqs: -32%
  • startupPowerUserHome/uiStartup: -27%
  • startupPowerUserHome/backgroundConnect: -15%
  • startupPowerUserHome/setupStore: -14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 760ms
  • 🔴 startupPowerUserHome/INP: p75 728ms
  • 🟡 startupPowerUserHome/LCP: p75 3.8s
  • 🟡 startupPowerUserHome/LCP: p75 3.7s
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-browserify
onboardingImportWallet🟡 [Show logs]
onboardingNewWallet🟡 [Show logs]
assetDetails🟡 [Show logs]
solanaAssetDetails🟡 [Show logs]
importSrpHome
🔴 cls
[Show logs]
sendTransactions🟢 [Show logs]
swap
🔴 cls
[Show logs]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: -85%
  • onboardingImportWallet/metricsToWalletReadyScreen: -46%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/total: -21%
  • onboardingNewWallet/srpButtonToPwForm: -78%
  • onboardingNewWallet/skipBackupToMetricsScreen: -66%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -21%
  • onboardingNewWallet/total: -13%
  • assetDetails/assetClickToPriceChart: +192%
  • assetDetails/total: +192%
  • solanaAssetDetails/assetClickToPriceChart: -20%
  • solanaAssetDetails/total: -20%
  • importSrpHome/loginToHomeScreen: -14%
  • importSrpHome/openAccountMenuAfterLogin: -63%
  • importSrpHome/homeAfterImportWithNewWallet: -52%
  • importSrpHome/total: -45%
  • swap/openSwapPageFromHome: -92%
  • swap/total: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 onboardingImportWallet/FCP: p75 2.3s
  • 🟡 onboardingNewWallet/FCP: p75 2.0s
  • 🟡 assetDetails/INP: p75 336ms
  • 🟡 assetDetails/FCP: p75 2.6s
  • 🟡 solanaAssetDetails/INP: p75 224ms
  • 🟡 solanaAssetDetails/FCP: p75 2.5s
  • 🟡 importSrpHome/INP: p75 304ms
  • 🟡 importSrpHome/FCP: p75 2.6s
  • 🟡 importSrpHome/CLS: p75 0.105
  • 🟡 swap/FCP: p75 2.5s
  • 🟡 swap/CLS: p75 0.143
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-browserify
dappPageLoad🟢 [Show logs]
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template size-XS team-wallet-integrations Wallet Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants