Skip to content

Remove validation error for regional rivers #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sam Clarke-Green (t00sa) merged 4 commits into from
Jul 17, 2026
+4 −6
Merged

Remove validation error for regional rivers #31

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b3138c
remove river failure
james-bruten-mo Feb 26, 2026
7bca4c9
add comment
james-bruten-mo Jul 15, 2026
12ea441
Update mule/lib/mule/validators.py
james-bruten-mo Jul 17, 2026
07968b6
Merge branch 'main' into rivers_validation
t00sa Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions mule/lib/mule/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,12 +570,10 @@ def validate_regular_field(umf, field):
n_row_exp += 1
elif field.stash.grid == 23:
# River routing grid
if umf.fixed_length_header.horiz_grid_type != 0:
return ["Field is river routing diag, which is invalid "
"for non-Global domains"]
else:
# Note the river routing diagnostics are restriced to a very
# specific fixed grid; any deviation from this is incorrect
# No validation is done for regional rivers
if umf.fixed_length_header.horiz_grid_type == 0:
# Note the river routing diagnostics are restricted to a very
# specific fixed global grid; any deviation from this is incorrect
lon_start_exp = 0.5
lat_start_exp = -89.5
n_row_exp = 180
Expand Down
Loading