Remove validation error for regional rivers - #31
Merged
Sam Clarke-Green (t00sa) merged 4 commits intoJul 17, 2026
Conversation
Sam Clarke-Green (t00sa)
requested changes
Jul 17, 2026
Sam Clarke-Green (t00sa)
left a comment
Collaborator
There was a problem hiding this comment.
Looks sensible but we might as well fix a spelling mistake in the comment while we're at it...
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Sam Clarke-Green (t00sa)
approved these changes
Jul 17, 2026
Sam Clarke-Green (t00sa)
left a comment
Collaborator
There was a problem hiding this comment.
Approved!
Sam Clarke-Green (t00sa)
approved these changes
Jul 17, 2026
Sam Clarke-Green (t00sa)
left a comment
Collaborator
There was a problem hiding this comment.
Re-approving after merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code Reviewer: Sam Clarke-Green (@t00sa)
The mule validators raise an error if trying to run with regional rivers. However this is no longer valid (see this discussion). This removes the validation error for these scenarios.
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Test Suite Results - um - um_for_mule_rivers/run1
Suite Information
Approvals
Code Owners
Config Owners
No UM Config Owners Required
Task Information
✅ succeeded tasks - 43
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Code Review