Conversation
This was referenced Sep 12, 2026
Contributor
Author
|
@MrAlders0n please review this change with your Claude agent as part of the September 13 Beacon review batch. The current candidate is Please check the header and open controls at narrow widths, keyboard focus, longer region labels and the desktop layout. Issue #30 is linked for closure on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes #30. The fixed-height single-row header overflows at phone widths: in the reproduced 320px viewport, the LIVE badge is clipped and the GitHub link ends about 47px beyond the usable page width.
Use two header rows below the existing
mdbreakpoint, with the region/theme pickers on the second row. Keep the desktop single row and its 42px minimum height. The wordmark can truncate when status messages need room, and the region panel anchors from the left so it stays on screen. No controls are removed, no dependency is added, and the region input's focus behavior is unchanged (#29 remains separate).Type of change
Checklist
npm run buildpassesnpm run lintpassesnpm testpasses (725 tests)CONTRIBUTING.mdTesting notes
Added a real-browser geometry regression in
tests/browser/header-layout.js. It fails on the old layout for LIVE/GitHub overflow and passes on the candidate. It is a browser-console check because jsdom does not perform layout; the regular Vitest suite is separate.Checked 320, 360, 390, 767, 768 and 1280px viewports in Chromium, both pickers open at 320px, a longer IATA selection, Escape focus restoration, and the rate-limit badge using temporary local API responses. The mock was removed afterward. This is not a physical Safari/iOS validation claim.
AI tools assisted implementation and validation under the contributor's standing approval for this effort.
The native Pi build/lint and all 725 tests also pass, along with GitHub Actions CI. The preview serves
5c5c75awith the existing server candidate. The published HTML/source hashes match, both open pickers fit at phone width, the desktop header stays on one row, and normal browsing remains LIVE. No service restart was needed.