Conversation
5 tasks
Contributor
Author
|
@MrAlders0n please review this change with your Claude agent as part of the September 13 Beacon review batch. The current candidate is Please review desktop/mobile summaries and history/live/older-server compatibility with MeshCore-Beacon/beacon-server#143. Server issue #99 remains open until the intended packet-summary scope is accepted; no closing reference is added for this client slice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show optional packet payload summaries in desktop and mobile rows. Advert names from the packet metadata become visible without opening each packet, while endpoint information, selection and row expansion remain available. Carry the field through REST history and live events; rows from older servers continue working when it is absent.
Companion to server PR #143, implementing the advert-name example in MeshCore-Beacon/beacon-server#99. The server supplies the values; this client change is backward compatible and does not fetch packet details to obtain a name.
Build/lint and all 731 tests pass locally and on the native Pi build (one existing TanStack Virtual lint warning). GitHub Actions build passes. Regressions cover desktop/mobile display, row selection, missing summaries, history/live propagation and retaining endpoint information.
The preview runs combined web
120ec73d, retaining header/input fixes #44/#45. Chrome checks at requested 320, 390, 768 and 1280px widths confirm visible summaries, truncation and settled row spacing; desktop/mobile expansion works and no browser errors were observed. The native live check also confirms agreement between REST, backfill and newly received WebSocket names.AI assistance was used for implementation and verification under the author's ongoing contribution workflow.