Skip to content

preflight: mlx-metal-0-40-2 and metal-0-40-2 admit the v0.40.3 lineage #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glennneuber merged 1 commit into from
Oct 13, 2026
Merged

preflight: mlx-metal-0-40-2 and metal-0-40-2 admit the v0.40.3 lineage #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions docs/maxusai/vision-suite/preflight/expectations.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,10 @@ platform = "mlx-metal"
# (631109b34), with MLX-C unchanged at ebc88f10. A new profile by the ADR 0011 rule
# that created every predecessor: a payload move gets its own profile even when
# the numbers turn out identical, because "identical" is a measurement.
version_pattern = '^0\.40\.2-dynres(\.\d+)?-\d+-g[0-9a-f]{7,40}$'
# Widened 2026-10-14 to 0.40.3 for the v0.40.3 fold (#488), as ADR 0032 says for a Go-only fold: v0.40.3 moves no
# native input (MLX a59cc231 and llama.cpp b11351 stay), so its builds share this payload and this profile. Its
# head, 0.40.2-dynres.1-6-g9f3baaf, passed here (PASS=23 SKIP=16). 0.40.4 stays refused: its rc1 moves llama.cpp.
version_pattern = '^0\.40\.[23]-dynres(\.\d+)?-\d+-g[0-9a-f]{7,40}$'
# Admits the v0.40.2-dynres tag's lineage and its .N point tags (v0.40.2-dynres.1
# moves Go only on Metal; its one native change, #462's 903, is in ggml-cuda/mmq.cu,
# which this build does not compile), and nothing else: not -dirty, not the legacy
Expand Down Expand Up @@ -874,8 +877,9 @@ platform = "metal"
# the build production serves: --platform metal exited 2 on 0.40.2-dynres while
# mlx-metal-0-40-2 resolved. Same binary, same host, one stack gated and the other
# not. The payload is the one mlx-metal-0-40-2 pins, so its version pattern and
# llama_cpp_build are the same, .N point tags included (#486).
version_pattern = '^0\.40\.2-dynres(\.\d+)?-\d+-g[0-9a-f]{7,40}$'
# llama_cpp_build are the same, .N point tags included (#486), and the Go-only v0.40.3
# fold with it (#488: its head passed here, PASS=6 SKIP=12).
version_pattern = '^0\.40\.[23]-dynres(\.\d+)?-\d+-g[0-9a-f]{7,40}$'
llama_cpp_build = "631109b34"
# The compat series as llama/compat applies it to b11351 (#460): every patch
# applies to the source tree; 903 and 908 touch CUDA files only, which a Metal
Expand Down
8 changes: 6 additions & 2 deletions docs/maxusai/vision-suite/preflight/test_verdicts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1915,8 +1915,11 @@ class TestMlxMetalProfileForTheV0402Fold(unittest.TestCase):
"0.40.2-dynres-0-gabcdef0", # the fold's tag stamp
"0.40.2-dynres-5-g0123456", # a build after that tag
"0.40.2-dynres.1-0-gabcdef0", # the v0.40.2-dynres.1 point tag (Go-only on Metal)
"0.40.2-dynres.1-6-g9f3baaf", # the v0.40.3 fold's head, measured here (#488)
"0.40.3-dynres-0-gabcdef0", # the v0.40.3 fold: Go-only, the same payload (ADR 0032)
)
REJECT = (
"0.40.4-dynres-0-gabcdef0", # v0.40.4 moves llama.cpp to b11521: measure first
"0.35.0-dynres-0-g043f441", # production's build: mlx-metal-0-34-4's
"0.35.0-dynres-27-g948ef3a", # the fold's interim stamp: not admitted by widening
"0.40.1-dynres-0-gabcdef0", # an upstream release this fold passed through
Expand Down Expand Up @@ -1965,9 +1968,10 @@ class TestMetalProfileForTheV0402Fold(unittest.TestCase):

PROFILE = "metal-0-40-2"
ADMIT = ("0.40.2-dynres-0-g5623192", "0.40.2-dynres-5-g0123456",
"0.40.2-dynres.1-0-g3960244") # the point tag, as mlx-metal-0-40-2 admits it (#486)
"0.40.2-dynres.1-0-g3960244", # the point tag, as mlx-metal-0-40-2 admits it (#486)
"0.40.3-dynres-0-gabcdef0") # the Go-only v0.40.3 fold (#488)
REJECT = ("0.35.0-dynres-0-g043f441", "0.32.14-maxusai-abcdef0", "0.40.2-dynres-0-gabcdef0-dirty",
"0.40.2-dynres.1-0-gabcdef0-dirty")
"0.40.2-dynres.1-0-gabcdef0-dirty", "0.40.4-dynres-0-gabcdef0")

@classmethod
def setUpClass(cls):
Expand Down