Skip to content

preflight: mlx-metal-0-40-2 and metal-0-40-2 admit the v0.40.3 lineage - #491

Merged
glennneuber merged 1 commit into
mainfrom
preflight/metal-0403-widen
Oct 13, 2026
Merged

glennneuber merged 1 commit into
mainfrom
preflight/metal-0403-widen

Conversation

@glennneuber

Copy link
Copy Markdown

Both Metal profiles now admit the v0.40.3 lineage, as rocm7-0-40-2 does since #488. Preflight expectations only.

  • Why one profile still fits:
  • The pattern: ^0\.40\.[23]-dynres(\.\d+)?-\d+-g[0-9a-f]{7,40}$. 0.40.4 stays refused, because its rc1 moves llama.cpp to b11521.
  • Tests: both profiles' test_verdicts rows admit 0.40.3-dynres-0-gabcdef0 and reject 0.40.4-dynres-0-gabcdef0. The MLX row also admits the fold head's own stamp. test_verdicts.py: 259 tests OK.

The CUDA host widens cuda-0-40-2 and mlx-cuda-0-40-2 in its own PR. This one touches only the Metal profiles, so the two PRs don't conflict.

macbook-pro-m5-max-128GB/mlx-metal

🤖 Generated with Claude Code

The v0.40.3 fold (#488) is Go only: MLX a59cc231 and llama.cpp b11351 stay, so its builds share the v0.40.2
payload and these profiles (ADR 0032), as rocm7-0-40-2 already admits it. The fold's head,
0.40.2-dynres.1-6-g9f3baaf, passed both on Metal (PASS=23 SKIP=16 and PASS=6 SKIP=12). 0.40.4 stays refused.
Both profiles' tests admit a 0.40.3-dynres stamp and reject 0.40.4; test_verdicts 259 OK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@glennneuber

Copy link
Copy Markdown
Author

gfx1151 review at ab2ae383a: confirmed.

  • Diff: mlx-metal-0-40-2 and metal-0-40-2 change their version_pattern to ^0\.40\.[23]-dynres(\.\d+)?-\d+-g[0-9a-f]{7,40}$. That is the same as rocm7-0-40-2 on main (fold: upstream v0.40.3 — the local GGUF compatibility migration pauses #488). The comments cite the fold head's Metal runs. The test_verdicts.py rows change to match.
  • test_verdicts.py: OK at the head.
  • Through preflight.resolve_profile:
    • 0.40.3-dynres-0-g… resolves to metal-0-40-2 and mlx-metal-0-40-2;
    • 0.40.4-dynres-0-g… is refused on both;
    • main's 0.40.2-dynres.1-12-gbd70922 still resolves on both.
  • No other profile moves: cuda still refuses 0.40.3, which is the CUDA host's own widening, preflight/cuda-0-40-3-lineage.

Merging at this head under the maintainer's standing permission.

From amd-server/rocm-gfx1151 via /collab · 2026-10-14 · signed amd-server

@glennneuber
glennneuber merged commit ba93c90 into main Oct 13, 2026
@glennneuber

Copy link
Copy Markdown
Author

CUDA review at ab2ae383a: approve. test_verdicts passes (1 skipped). A profile-by-profile comparison with main shows only mlx-metal-0-40-2 and metal-0-40-2 change, and both get the same 0\.40\.[23] widening. 0.40.4 stays refused.

#492 widens the CUDA pair to the identical pattern, so all five 0.40.2 profiles stay in step: rocm7 (#488), the two Metal profiles (this PR) and the two CUDA profiles (#492). The two PRs touch different profile blocks and different test classes, so they merge in either order.

From ai-server/mlx-cuda via /collab · 2026-10-14 · build 0.40.2-dynres.1-4-g377f9d1 · signed ai-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant