Including installation for metis in dockerfile#207
Open
bundle-adjuster wants to merge 2 commits into
Open
Conversation
Seems like metis was a hidden dependency that doesn't break the installation. But gives error when trying to execute the tests. Adding metis to the dockerfile seems to have fixed everything. Not sure if some dependency of metis caused this or metis itself. For now this docker build seems to be stable. The requirement for timezone still exists. Adding TZ env did not seem to solve the issue will raise another PR if the fix seems to work.
Author
|
Request review from @Wallbraker @violetteavi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like metis was a hidden dependency that doesn't break the installation. But gives error when trying to execute the tests. Adding metis to the dockerfile seems to have fixed everything. Not sure if some dependency of metis caused this or metis itself. For now this docker build seems to be stable.
Note:
The requirement for timezone still exists. Adding TZ env did not seem to solve the issue will raise another PR if the fix seems to work.