ci(coverage): use app token for push (persist-credentials: false)#1466
Merged
sbryngelson merged 1 commit intoMay 30, 2026
Merged
Conversation
…r the push actions/checkout persists the default GITHUB_TOKEN as an http.extraheader that overrides the app-token credentials embedded in the push URL, so the push authenticated as github-actions[bot] (not a ruleset bypass actor) and was rejected by the require-PR rule. persist-credentials: false lets the mfc-map-bot app token actually be used, so its ruleset bypass applies. This lets the require-PR rule be restored while the bot still pushes the refreshed map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The previous run minted the
mfc-map-botapp token correctly, but the push still hitGH013 ... Changes must be made through a pull requesteven with the app on the ruleset bypass list.Reason:
actions/checkoutpersists the defaultGITHUB_TOKENas anhttp.https://github.com/.extraheaderauth header, which overrides the app-token credentials embedded in the push URL. So the push authenticated asgithub-actions[bot](not a bypass actor) and was rejected by the require-PR rule. The bypass config was correct all along; the push just never used the app identity.Refs: community #136531, community #72173, create-github-app-token #81.
Fix
persist-credentials: falseon the checkout step, so the push uses the app-token URL. The SLURM build/collect needs no persisted git credentials (it only reads viagit rev-parse/git diffand installs public deps), so this is safe.Follow-up (restores protection)
With this merged, the
pull_request(require-PR) rule can be re-added to the master ruleset: humans still need PRs, and only themfc-map-botapp bypasses it. I'll restore the rule and dispatch a verification run once this lands.