ci(coverage): push refreshed map via classic PAT (CACHE_PUSH_TOKEN)#1467
Merged
sbryngelson merged 1 commit intoMay 30, 2026
Merged
Conversation
GitHub Apps cannot bypass the require-PR ruleset rule for direct pushes (documented limitation), so the app-token approach was abandoned. A classic PAT from an org-owner authenticates as a user with OrganizationAdmin bypass, which IS honored. Verified via a smoke-test that pushed to protected master with require-PR active. persist-credentials:false (already on master) ensures the PAT is the identity used, not GITHUB_TOKEN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The coverage-refresh push to master needs to bypass the
masterruleset's require-PR rule. We tried a GitHub App (mfc-map-bot), but GitHub Apps cannot bypass the require-PR rule for direct pushes — a documented limitation (discussion #136531). A classic PAT authenticates as a user; an org-owner user is anOrganizationAdmin, which is an honored bypass actor.Change
Push with
CACHE_PUSH_TOKEN(now a classic org-owner PAT,reposcope) instead of the app token. Thepersist-credentials: falsefix from #1466 is retained — it ensures the PAT is the identity used for the push rather than the hijackingGITHUB_TOKENextraheader (the real reason every earlier attempt failed).Verified
A throwaway smoke-test workflow pushed a commit to protected master with require-PR active using exactly this mechanism — it landed (
mfc-bot test: pat-push smoketest), then was cleaned up. So the full chain (SLURM collect →--no-verifycommit → PAT push) is proven end-to-end.Follow-up cleanup
Integrationbypass actor (mfc-map-bot) from the master ruleset.mfc-map-botApp and its secrets (MAP_BOT_APP_ID,MAP_BOT_APP_PRIVATE_KEY) can be deleted.