Repository navigation
ci: compile the CUDA lane for AMPERE86 too; docs: API fixes need no SEP - #845
Merged
Merged
Conversation
The device-compile lane now builds the cuda preset for HOPPER90 and for AMPERE86, and runs the lambda-tag check over each build. Only an AMPERE86 build compiles the device GEMM that caused #815. AGENTS.md, contributing.md and SEP 0 section 2 no longer list a public interface redesign as needing a SEP. API fixes and cleanups that change no model or physics follow the ordinary issue and pull-request path (maintainer's decision, recorded in SEP 0's log). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
jtravs
marked this pull request as ready for review
November 15, 2026 20:38
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jtravs
added a commit
that referenced
this pull request
Nov 16, 2026
The changes job diffed against the event's pull_request.base.sha, which can lag behind main: it stayed at 281a954 on #847 after #845 merged, so #845's ci.yml and native/ changes were counted as #847's own and the docs-only PR ran every lane. The checkout is GitHub's merge of the head into main's current tip, so its first parent is the right base. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small maintainer decisions:
CI (follow-up to #815).
device-compile-cudanow runs as a matrix overHOPPER90(the preset's target) andAMPERE86(NVIDIA A40). The A40 radial crash came fromdevice_dense_gemm, which only anAMPERE86build compiles, so the lambda-tag check added in #841 could not see it on the old lane. Each CUDA build now runs the check over its own objects.device-compile (CUDA 12.8, <arch>); onlyci-passedis a required check, and it already depends on this job.docs/dev/tooling.mdand the check's docstring describe the new lane.SEP threshold.
AGENTS.md,docs/dev/contributing.mdand SEP 0 §2 no longer list "a redesign of a public interface" as needing a SEP. API fixes and cleanups that change no model or physics now follow the ordinary issue-and-PR path, even when they rename, merge or refuse public parameters. Physics defaults and conventions, new models and schemes, and kernel-contract changes still need one. SEP 0's log records the decision with today's date.This PR changes CI and docs only, with no code behaviour and no changelog fragment.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH