Repository navigation
ci: diff a pull request against its merge commit's first parent - #852
Merged
Merged
Conversation
The changes job diffed against the event's pull_request.base.sha, which can lag behind main: it stayed at 281a954 on #847 after #845 merged, so #845's ci.yml and native/ changes were counted as #847's own and the docs-only PR ran every lane. The checkout is GitHub's merge of the head into main's current tip, so its first parent is the right base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jtravs
enabled auto-merge (squash)
November 15, 2026 23:20
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only PRs (#847, #850) were running every lane.
Cause. The
changesjob diffed againstgithub.event.pull_request.base.sha. That value can be older than main's tip. On #847's latest run it was still281a9543, from before #845 merged. The checked-out merge commit, though, was built against today's main (33efe0cb). So the diff counted #845's.github/workflows/ci.ymlandnative/ci/check_lambda_tags.pyas #847's own changes, which gavelanes=fullanddevice=true.Fix. On a
pull_requestevent, when HEAD is GitHub's test merge commit, the job now diffs against that commit's first parent, which is the base tip the merge was built on. Push events still usegithub.event.before. If HEAD is not a merge commit, the job falls back tobase.shaas before.Checked. On #847's merge ref (
e0b7b40b),git diff --name-only HEAD^1 HEADlists onlydocs/dev/roadmap.md,docs/dev/seps/index.mdanddocs/dev/seps/sep-0051-save-planes.md, so the job would picklanes=docsanddevice=false. This PR touchesci.yml, so its own run takes the full lanes. That run checks the edited script itself.🤖 Generated with Claude Code