Repository navigation
Fix: Draw the top bar again wherever it was drawn away from its clicks - #189
Merged
Merged
Conversation
On Whale the browser moves the panel without the layout notice the bar repaints on, so after a fold the bar stayed drawn at its old place. Folding now asks for a repaint, and a hit test that finds the bar's place differs from where it was drawn asks for one before the click arrives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
b-re-w
force-pushed
the
feat/bar-place
branch
from
November 9, 2026 20:17
a0d7d4d to
0116f7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #184, the release bar-folded scene passes on Chrome and Edge (.scratch\bar-rows-after). It still fails on Whale 5.39: after each fold or show, the bar stays painted at its previous place, for example "step 2 shown by the button: Back painted at 59-94 hits 2". Whale moves the panel without the frame layout notice that
panel_movedhangs on.toggle_appbarasks for a bar repaint (frame::request_bar_paint, the postedRivet.BarMoved).address_bar::part_at, which the window's hit test uses, asks for a repaint when the bar's place for clicks differs from whereviewlast drew it. The pointer's own hit tests come before any click, so the bar is drawn where it takes clicks first.Test:
fr12_a_bar_drawn_where_it_no_longer_takes_clicks_is_drawn_again.🤖 Generated with Claude Code