Repository navigation
Fix: Read browser memory in place in the tab strip, app window and browser readers - #185
Merged
Merged
Conversation
…owser readers The tab strip's, the app window's and the browser access layer's readers made a system call for every word of browser memory, as the second view's did. Memory already known readable is now read in place, with ReadProcessMemory kept for the rest. The top bar's own repaint traces its steps when it takes 2 ms or more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #183. After it, release address-typing (.scratch\typing-after-release) gave Rivet work per key median/p90:
Most of what is left is the top bar's own paint (draw median 7 to 19 ms). Its view reads the open tabs through the tab strip reader, and that reader made one ReadProcessMemory call per word, as
second_view's did. This applies the same in-place read (aftermemory::readable) totab_strip::read,app_window::safe_wordandbrowser::chromium::read_word. It also tracestop bar: update took N us: view .. paint ..over 2 ms, so the next measurement splits the view from the paint.Covered by
nfr2_browser_words_are_read_in_place_once_readable(#183); the after numbers come from the same scene.🤖 Generated with Claude Code