Repository navigation
Fix: Draw the top bar for a typing message only when what it shows changed - #188
Merged
Merged
Conversation
…anged The text engine reports a change for a key down before its character and for a key up, so each key still drew the bar three times. A message now draws only when the text, its selection, the caret, the list, its pick or the inline completion changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release address-typing on Chrome after #183-#185 (.scratch\bar-rows-after): Rivet work per key median 14.3 ms, p90 22.7. Per message: key down 3.8 ms, character 8.0 ms (draw 4.2), key up 3.8 ms. Key down and key up still drew, because the text engine's own change report fires for them and bumped the bar's generation.
The draw decision now compares what the bar shows (text, selection, caret, list size, pick, inline completion) before and after the message. Test:
nfr2_a_key_that_shows_nothing_new_draws_nothing.🤖 Generated with Claude Code