Repository navigation
Fix: Keep the top bar's controls where they take clicks when the appbar folds - #184
Merged
Merged
Conversation
…ar folds Folding the appbar moves the browser's panel, and the top bar with it, but the bar was painted again only on a later event, so its buttons showed at their old place while the clicks went to the new one. The bar now repaints right after the browser moves the panel. The window's hit test also gives the bar's controls to the bar itself, from the places it paints them, where the browser's own hit test called them title bar on Chrome, Brave and Samsung Internet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three tabs with a pin and a folder, then three folds and three shows, by the appbar's own fold button where the runtime traced it and by the command, with every control checked and clicked after each change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner report: with the appbar folded, the top row's buttons are misplaced and cannot be pressed (seen on held Edge 156).
Reproduced with the bar-folded scene from #182 (release build, .scratch\fold-before):
Fix:
panel_moved(the browser laid the panel out somewhere new) postsRivet.BarMoved, which repaints the top bar after that layout.hit_testanswers HTCLIENT for a point on a bar control (address_bar::part_at, the same places the bar is painted from) before the title row rules.Test:
fr12_each_control_answers_where_it_is_painted_shown_and_folded. After numbers follow from the same scene on all five once merged.🤖 Generated with Claude Code