Skip to content

fix(sunshine): backport upstream OpenSSL and metainfo fixes - #104

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/backport-sunshine-build-fixes
Nov 12, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/backport-sunshine-build-fixes

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Description

Sunshine 2026.914.233613 predates the OpenSSL 4.1 compatibility fix and still bundles a screenshot URL that returns 404. Backport the upstream fixes to the pinned release while retaining BUILD_WERROR=ON.

  • Apply the source-only OpenSSL fix from dac66dfd.
  • Backport the final crypto test and signature documentation changes from SunshineStream/Sunshine#6005, including the binary-signature regression test and supported subject-name API. Adapt the test include context to the release.
  • Apply only the AppStream metainfo changes from 357bd98c, updating the screenshot, bug tracker, and release URLs.
  • Register all three versioned patches with SHA-256 checksums, apply them in prepare(), and bump pkgrel to 2 with matching .SRCINFO.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • bash -n pkgbuilds/sunshine/PKGBUILD passed in MSYS2 UCRT64.
  • _use_cuda=true makepkg --printsrcinfo exactly matched the checked-in .SRCINFO.
  • GNU patch --dry-run --fuzz=0 -Np1 passed for all three patches against files fetched from the pinned source commit 63d35f702ee9e362e43263742981836ec0710384.
  • Applied all three patches with git apply, verified every SHA-256 checksum, and compared all four resulting files with the upstream-derived expected content.
  • Parsed the patched metainfo and verified its screenshot returns HTTP 200 with image/jpeg.
  • git diff --cached --check passed for PKGBUILD and .SRCINFO; patch files passed with the whitespace checks for standard blank patch-context lines disabled.
  • Full Arch package compilation and C++ test execution were not run locally on Windows; those remain for the existing hosted build workflow. The backported GoogleTest case checks preservation of every signature byte value, including embedded NULs.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

Codex prepared and validated the upstream backports and this description.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 724912c into master Nov 12, 2026
9 of 10 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/backport-sunshine-build-fixes branch November 12, 2026 02:24
Misaka13514 added a commit to archlinuxcn/repo that referenced this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant