Skip to content

fix(sunshine): fix build with openssl 4 and update metainfo screenshot url - #103

Closed
Misaka13514 wants to merge 1 commit into
LizardByte:masterfrom
Misaka13514:patch
Closed

Misaka13514 wants to merge 1 commit into
LizardByte:masterfrom
Misaka13514:patch

Conversation

@Misaka13514

@Misaka13514 Misaka13514 commented Nov 11, 2026 •

Copy link
Copy Markdown

Description

This PR fixes two build failures on Arch Linux:

  1. OpenSSL 4.1 deprecation warning treated as error:
    With OpenSSL 4.x on Arch Linux, ASN1_STRING_length is deprecated in favor of ASN1_STRING_get_length, triggering
    -Werror=deprecated-declarations.
    While this is already addressed upstream in fix: support OpenSSL 4.1 and current Homebrew ICU SunshineStream/Sunshine#6005, the current release (2026.914.233613) predates that fix. Setting
    -D BUILD_WERROR=OFF allows compilation to succeed until the next release is tagged.
  2. AppStream screenshot validation failure:
    The legacy screenshot URL in the bundled manifest returned 404. Updated the manifest URL in prepare() to
    https://sunshine.lizardbyte.dev/assets/sunshine-web-ui-dark.jpg.
  3. Bumped pkgrel to 2 and synced .SRCINFO.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@CLAassistant

CLAassistant commented Nov 11, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ReenigneArcher

Copy link
Copy Markdown
Member

For item 2, the path changed to https://github.com/SunshineStream/SunshineStream.github.io/blob/master/assets/sunshine-web-ui-dark.jpg

The proper fix is to update the manifest.

@Misaka13514 Misaka13514 changed the title fix(sunshine): fix build with openssl 4 and skip appstream network validation fix(sunshine): fix build with openssl 4 and update metainfo screenshot url Nov 11, 2026
@Misaka13514

Misaka13514 commented Nov 11, 2026 •

Copy link
Copy Markdown
Author

@ReenigneArcher Thanks for pointing that out, I've updated prepare() in the PKGBUILD to patch the manifest to https://sunshine.lizardbyte.dev/assets/sunshine-web-ui-light.jpg instead of using --nonet.

I've also opened a PR on Sunshine upstream to update the metainfo file directly:

…t url

- Set BUILD_WERROR=OFF to prevent build failure from OpenSSL 4.1 deprecation warnings (ASN1_STRING_length)
- Update screenshot URL in metainfo to sunshine-web-ui-dark.jpg in prepare()
- Bump pkgrel to 2
@sonarqubecloud

Copy link
Copy Markdown

Misaka13514 added a commit to archlinuxcn/repo that referenced this pull request Nov 11, 2026
@ReenigneArcher

Copy link
Copy Markdown
Member

I fixed this a different way in #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants