Repository navigation
fix(sunshine): fix build with openssl 4 and update metainfo screenshot url - #103
Closed
Misaka13514 wants to merge 1 commit into
Closed
Misaka13514 wants to merge 1 commit into
Misaka13514 wants to merge 1 commit into
Conversation
Member
|
For item 2, the path changed to https://github.com/SunshineStream/SunshineStream.github.io/blob/master/assets/sunshine-web-ui-dark.jpg The proper fix is to update the manifest. |
4 of 18 tasks
Author
|
@ReenigneArcher Thanks for pointing that out, I've updated
|
…t url - Set BUILD_WERROR=OFF to prevent build failure from OpenSSL 4.1 deprecation warnings (ASN1_STRING_length) - Update screenshot URL in metainfo to sunshine-web-ui-dark.jpg in prepare() - Bump pkgrel to 2
|
Misaka13514
added a commit
to archlinuxcn/repo
that referenced
this pull request
Nov 11, 2026
9 of 18 tasks
Member
|
I fixed this a different way in #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes two build failures on Arch Linux:
With OpenSSL 4.x on Arch Linux,
ASN1_STRING_lengthis deprecated in favor ofASN1_STRING_get_length, triggering-Werror=deprecated-declarations.While this is already addressed upstream in fix: support OpenSSL 4.1 and current Homebrew ICU SunshineStream/Sunshine#6005, the current release (
2026.914.233613) predates that fix. Setting-D BUILD_WERROR=OFFallows compilation to succeed until the next release is tagged.The legacy screenshot URL in the bundled manifest returned 404. Updated the manifest URL in
prepare()tohttps://sunshine.lizardbyte.dev/assets/sunshine-web-ui-dark.jpg.pkgrelto 2 and synced.SRCINFO.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Type of Change
Checklist
AI Usage
See our AI usage policy.