Skip to content

[lua] Update COR roll effect luas #10329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xaver-DaRed merged 1 commit into from
Jun 16, 2026
Merged

[lua] Update COR roll effect luas #10329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/effects/beast_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ end
effectObject.onEffectLose = function(target, effect)
target:delPetMod(xi.mod.ATTP, effect:getPower())
target:delPetMod(xi.mod.RATTP, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

return effectObject
3 changes: 1 addition & 2 deletions scripts/effects/blitzers_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.DELAYP, effect:getPower())
effect:addMod(xi.mod.DELAYP, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.DELAYP, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/casters_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.FASTCAST, effect:getPower())
effect:addMod(xi.mod.FASTCAST, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.FASTCAST, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
7 changes: 3 additions & 4 deletions scripts/effects/chaos_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,15 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.ATTP, effect:getPower())
target:addMod(xi.mod.RATTP, effect:getPower())
effect:addMod(xi.mod.ATTP, effect:getPower())
effect:addMod(xi.mod.RATTP, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.ATTP, effect:getPower())
target:delMod(xi.mod.RATTP, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

return effectObject
3 changes: 1 addition & 2 deletions scripts/effects/choral_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.SPELLINTERRUPT, effect:getPower())
effect:addMod(xi.mod.SPELLINTERRUPT, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.SPELLINTERRUPT, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
6 changes: 2 additions & 4 deletions scripts/effects/corsairs_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,15 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.EXP_BONUS, effect:getPower())
target:addMod(xi.mod.CAPACITY_BONUS, effect:getPower())
effect:addMod(xi.mod.EXP_BONUS, effect:getPower())
effect:addMod(xi.mod.CAPACITY_BONUS, effect:getPower())
-- TODO: Exemplar Points (Not Implemented)
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.EXP_BONUS, effect:getPower())
target:delMod(xi.mod.CAPACITY_BONUS, effect:getPower())
-- TODO: Exemplar Points (Not Implemented)
xi.job_utils.corsair.onRollEffectLose(target, effect)
end
Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/coursers_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
-- target:addMod(xi.mod.SNAPSHOT, effect:getPower())
-- effect:addMod(xi.mod.SNAPSHOT, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
-- target:delMod(xi.mod.SNAPSHOT, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/dancers_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.REGEN, effect:getPower())
effect:addMod(xi.mod.REGEN, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.REGEN, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/evokers_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.REFRESH, effect:getPower())
effect:addMod(xi.mod.REFRESH, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.REFRESH, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/fighters_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.DOUBLE_ATTACK, effect:getPower())
effect:addMod(xi.mod.DOUBLE_ATTACK, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.DOUBLE_ATTACK, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/gallants_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.DMG, -effect:getPower())
effect:addMod(xi.mod.DMG, -effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.DMG, -effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/healers_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.CURE_POTENCY_RCVD, effect:getPower())
effect:addMod(xi.mod.CURE_POTENCY_RCVD, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.CURE_POTENCY_RCVD, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
6 changes: 2 additions & 4 deletions scripts/effects/hunters_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,14 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.ACC, effect:getPower())
target:addMod(xi.mod.RACC, effect:getPower())
effect:addMod(xi.mod.ACC, effect:getPower())
effect:addMod(xi.mod.RACC, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.ACC, effect:getPower())
target:delMod(xi.mod.RACC, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/maguss_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.MDEF, effect:getPower())
effect:addMod(xi.mod.MDEF, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.MDEF, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/misers_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.SAVETP, effect:getPower())
effect:addMod(xi.mod.SAVETP, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.SAVETP, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/monks_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.SUBTLE_BLOW, effect:getPower())
effect:addMod(xi.mod.SUBTLE_BLOW, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.SUBTLE_BLOW, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/naturalists_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.ENH_MAGIC_DURATION, effect:getPower())
effect:addMod(xi.mod.ENH_MAGIC_DURATION, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.ENH_MAGIC_DURATION, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/ninja_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.EVA, effect:getPower())
effect:addMod(xi.mod.EVA, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.EVA, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/rogues_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.CRITHITRATE, effect:getPower())
effect:addMod(xi.mod.CRITHITRATE, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.CRITHITRATE, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/runeists_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.MEVA, effect:getPower())
effect:addMod(xi.mod.MEVA, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.MEVA, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/samurai_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.STORETP, effect:getPower())
effect:addMod(xi.mod.STORETP, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.STORETP, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/scholars_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.CONSERVE_MP, effect:getPower())
effect:addMod(xi.mod.CONSERVE_MP, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.CONSERVE_MP, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
3 changes: 1 addition & 2 deletions scripts/effects/tacticians_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.REGAIN, effect:getPower())
effect:addMod(xi.mod.REGAIN, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.REGAIN, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

Expand Down
4 changes: 2 additions & 2 deletions scripts/effects/warlocks_roll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
local effectObject = {}

effectObject.onEffectGain = function(target, effect)
target:addMod(xi.mod.MACC, effect:getPower())
effect:addMod(xi.mod.MACC, effect:getPower())
end

effectObject.onEffectTick = function(target, effect)
end

effectObject.onEffectLose = function(target, effect)
target:delMod(xi.mod.MACC, effect:getPower())
xi.job_utils.corsair.onRollEffectLose(target, effect)
end

return effectObject
Loading
Loading