Skip to content

[lua] Update COR roll effect luas#10329

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
CriticalXI:cor_audit
Jun 16, 2026
Merged

[lua] Update COR roll effect luas#10329
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
CriticalXI:cor_audit

Conversation

@CriticalXI

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Updates all COR roll effect luas to apply the mod to the effect and remove it from onEffectLose where possible.
  • Adds a few missing onRollEffectLose function calls.

Steps to test these changes

  • Use COR rolls and allow them to wear off/wipe them
  • See the effect properly removes as expected

@Xaver-DaRed Xaver-DaRed merged commit 1263a49 into LandSandBoat:base Jun 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants