Skip to content

measure lock hold time, not reopen time, in the bridged storage lock test #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabracht merged 1 commit into from
Oct 11, 2026
Merged

measure lock hold time, not reopen time, in the bridged storage lock test #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/mqtt5/tests/broker_storage_lock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,16 +186,18 @@ async fn bridged_broker_releases_the_directory_promptly_after_shutdown() {
.expect("broker task joins")
.expect("broker run returns cleanly");
let began = Instant::now();
let mut attempt_began = began;
let mut reopened = FileBackend::new(dir.path()).await;
while reopened.is_err() && began.elapsed() < Duration::from_secs(2) {
tokio::time::sleep(Duration::from_millis(5)).await;
attempt_began = Instant::now();
reopened = FileBackend::new(dir.path()).await;
}
let waited = began.elapsed();
let held = attempt_began.duration_since(began);
drop(reopened.expect("directory is released after shutdown"));
assert!(
waited < Duration::from_millis(400),
"directory held for {waited:?} after run returned"
held < Duration::from_millis(400),
"directory held for {held:?} after run returned"
);

remote_shutdown.shutdown();
Expand Down
Loading