Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/baseline_check.py: compares geometry (X, Y) and panel-method results (Cl and the full Cp distribution) for NACA 0012, 2412 and 4412 at alpha = -4, 0, +5 deg (160 panels) with a saved reference. Tolerance: 1e-9.tests/baseline_reference.json: reference generated from the current code, before any refactor.Why
The next PRs move and rewrite the solver code (shared core, vectorized panel method). This check proves they don't change any number.
Cp is stored in full because Cl alone can miss errors: a test change to the tangential-velocity formula left Cl identical but changed Cp by up to 2e-5.
How to use
python tests/baseline_check.pymust end withAll 24 quantities match the baseline.--generaterefuses to overwrite an existing reference, so a refactor cannot silently replace it.Depends on
#3 (this PR is based on
chore/repo-hygiene). Merge #3 first and delete its branch: GitHub will then retarget this PR tomain.